Source: gimplensfun Version: 0.2.4-1.1 Severity: important Tags: patch upstream ftbfs Control: forwarded -1 https://github.com/seebk/GIMP-Lensfun/pull/30
Hi, gimplensfun fails to build with the new stable series of the Exiv2 library, i.e. 0.28.x; this version is now available in unstable. There is a proposed patch upstream to fix this [1], although it looks like it will wait a while as the upstream project does not look that active. I extracted the patch/commit from that upstream PR, and verified that it builds fine with Exiv2 0.28; you can find it attached to this bug. This bug should have been reported before Exiv2 0.28.x was uploaded to unstable: for some reason my testing did not uncover the compatibility issues in gimplensfun, sorry for this. Because of this, I'm going to NMU this soon. [1] https://github.com/seebk/GIMP-Lensfun/pull/30 Thanks, -- Pino
Author: Pino Toscano <toscano.p...@tiscali.it> Description: Support Exiv2 0.28+ Use the new types for the image pointer and exception class, as available in the new Exiv2 version, keeping the support for older versions. . Fixes #29 Last-Update: 2024-09-07 Forwarded: https://github.com/seebk/GIMP-Lensfun/pull/30 --- a/src/gimplensfun.cpp +++ b/src/gimplensfun.cpp @@ -34,6 +34,7 @@ #include <exiv2/error.hpp> #include <exiv2/image.hpp> #include <exiv2/exif.hpp> +#include <exiv2/version.hpp> #define VERSIONSTR "0.2.4" @@ -1033,7 +1034,11 @@ static void process_image (GimpDrawable // static int read_opts_from_exif(const char *filename) { +#if EXIV2_TEST_VERSION(0,28,0) + Exiv2::Image::UniquePtr Exiv2image; +#else Exiv2::Image::AutoPtr Exiv2image; +#endif Exiv2::ExifData exifData; const lfCamera **cameras = 0; @@ -1061,7 +1066,11 @@ static int read_opts_from_exif(const cha return -1; } } +#if EXIV2_TEST_VERSION(0,28,0) + catch (Exiv2::Error& e) { +#else catch (Exiv2::AnyError& e) { +#endif if (DEBUG) { g_print ("exception on reading data. \n"); }
