Package: detox
Version: 2.0.0-3
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu oracular ubuntu-patch
Dear Maintainer,
In Ubuntu, detox FTBFS because because _FORTIFY_SOURCE is redefined by
some Makefiles in the upstream source[1]. I uploaded a patch in Ubuntu
to remove the relevant entries in the upstream Makefiles so that distro
build flags take precedence.
* d/p/use-distro-fortify-source.patch: fix redefined _FORTIFY_SOURCE
(LP: #2079767)
Thanks for considering the patch.
[1] https://bugs.launchpad.net/ubuntu/+source/detox/+bug/2079767
diff -Nru detox-2.0.0/debian/patches/series detox-2.0.0/debian/patches/series
--- detox-2.0.0/debian/patches/series 2024-05-04 15:18:32.000000000 -0400
+++ detox-2.0.0/debian/patches/series 2024-09-05 21:26:12.000000000 -0400
@@ -1 +1,2 @@
010_remove-license-file.patch
+use-distro-fortify-source.patch
diff -Nru detox-2.0.0/debian/patches/use-distro-fortify-source.patch
detox-2.0.0/debian/patches/use-distro-fortify-source.patch
--- detox-2.0.0/debian/patches/use-distro-fortify-source.patch 1969-12-31
19:00:00.000000000 -0500
+++ detox-2.0.0/debian/patches/use-distro-fortify-source.patch 2024-09-05
21:26:12.000000000 -0400
@@ -0,0 +1,25 @@
+Description: Allow distro build flags to define _FORTIFY_SOURCE
+Author: Nick Rosbrook <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2079767
+Forwarded: no
+Last-Update: 2024-09-05
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -11,7 +11,6 @@
+ -DSYSCONFDIR=\"$(sysconfdir)\" \
+ -DYY_NO_INPUT \
+ -DYY_NO_UNPUT \
+- -D_FORTIFY_SOURCE=2 \
+ -Wall \
+ -Werror
+
+--- a/tests/unit/Makefile.am
++++ b/tests/unit/Makefile.am
+@@ -4,7 +4,6 @@
+ @CHECK_CFLAGS@ \
+ -DYY_NO_INPUT \
+ -DYY_NO_UNPUT \
+- -D_FORTIFY_SOURCE=2 \
+ -Wall \
+ -Werror
+
