Thanks, Graham. This looked easy enough so I cherry-picked this patch, but the build produces a ton symbol changes.
These are all C++ internal symbols that should not be public, I assume this is gcc-14 related. Since they not part of the public interface, I wouldn't have qualms forcefully updating them, but I'd nevertheless feel more comfortable spending a bit more time on this, to ensure this is either gcc-14- and/or patch-related. Best, Christian On 2024-08-26 19:10, Graham Inggs wrote: > Control: tags -1 + patch > > This is already fixed upstream: > https://github.com/ROCm/rocm_smi_lib/commit/12c8237705a91bd4096cfa4e9c0eac2d5305544b > > > --- a/include/rocm_smi/rocm_smi_utils.h > +++ b/include/rocm_smi/rocm_smi_utils.h > @@ -149,7 +149,7 @@ > __forceinline ~ScopeGuard() { > if (!dismiss_) release_(); > } > - __forceinline ScopeGuard& operator=(const ScopeGuard& rhs) { > + __forceinline ScopeGuard& operator=(ScopeGuard& rhs) { > dismiss_ = rhs.dismiss_; > release_ = rhs.release_; > rhs.dismiss_ = true; >
