Control: tag -1 patch

On Tue, Aug 06, 2024 at 06:46:37PM +0300, Niko Tyni wrote:
> Package: libatteanx-parser-jsonld-perl
> Version: 0.001-4
> Severity: important
> User: [email protected]
> Usertags: perl-5.40-transition

>   Changing use VERSION while another use VERSION is in scope is deprecated, 
> and will become fatal in Perl 5.44 at 
> /<<PKGBUILDDIR>>/blib/lib/AtteanX/Parser/JSONLD.pm line 43.
>   
>   #   Failed test 'no (unexpected) warnings (via done_testing)'

The attached patch changes the global 'use v5.14' to 'use v5.18'
instead so that the package-level 'use v5.18' is not needed anymore.
I've checked that it fixes the immediate issue.

I can't see any use of the new features that get enabled with this,
as described in perl5160delta or perl5180delta. I suppose it's still
possible that this breaks something. It does pass the test suite
though. Unfortunately there are no rdeps in the Debian archive to test
against.

Tentatively tagging 'patch'. Hope this helps.
-- 
Niko
From: Niko Tyni <[email protected]>
Date: Thu, 15 Aug 2024 16:12:42 +0100
X-Dgit-Generated: 0.001-4 27f2fadb36e084d6772b18ccb8d426ca2bfe7ae3
Subject: Use v5.18 throughout the module

Nested use VERSION declarations were deprecated in Perl 5.40.

Bug-Debian: https://bugs.debian.org/1078073

---

diff --git a/lib/AtteanX/Parser/JSONLD.pm b/lib/AtteanX/Parser/JSONLD.pm
index 049b123..17cc022 100644
--- a/lib/AtteanX/Parser/JSONLD.pm
+++ b/lib/AtteanX/Parser/JSONLD.pm
@@ -1,4 +1,4 @@
-use v5.14;
+use v5.18;
 use warnings;
 
 =head1 NAME
@@ -40,7 +40,6 @@ This class consumes the following roles:
 =cut
 
 package AtteanX::Parser::JSONLD::Handler {
-	use v5.18;
 	use autodie;
 	use Moo;
 	use Attean::RDF;

Reply via email to