Hey Samuel! On Wed, Jul 31, 2024 at 07:55:32PM +0900, Samuel Henrique wrote: > >> Severity: serious > >Could you please clarify why you think this severity is appropriate? >I'm tempted to lower it.
It's *very* different from normal packaging practice, just about the opposite of the "principle of least surprise". >> I'm maintaining a distro derived from Debian, and we've just tripped >> over issues in building the curl package with more patches applied. > >I take it this happened because the person did not read the comment in >d/p/series which says: >""" ># Do not add patches below. ># Used to generate packages for the other crypto libraries. >""" Correct. We have tooling that just appends patches. >> Why on earth are you doing this? It should surely be possible to apply >> all the needed patches and then use conditionals with automake in each >> build case. That would make a lot more sense. > >This was done a long time ago, I don't know who did it and why, and I didn't >cared enough to change it myself. > >> Please fix this surprising mess. > >Sounds like a nice contribution for a derivative to make, unless this affects >Debian directly (?) [0]. > >We are quite flexible with getting external contributions to the curl package, >the repository is in the debian org on salsa and you have my permission to >prepare a fix and push it straight there. > >We should then upload it within a week (depending on how we end up coordinating >the uploads for the next changes). I'm already working on the change... :-) -- Steve McIntyre, Cambridge, UK. st...@einval.com “Why do people find DNS so difficult? It’s just cache invalidation and naming things.” -– Jeff Waugh (https://twitter.com/jdub)
