M Hickford, Preamble...
Thank you for taking the time to create this package and your contribution to the Debian project. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Good 2. Lintian[2]: Minor I: git-credential-oauth source: unused-override unknown-field Go-Import-Path [debian/source/lintian-overrides:2] N: N: Your package specifies the named override but there were no tags that could have been silenced by N: it. N: N: Maybe you fixed an underlying condition but forgot to remove the override. It is also possible that N: the Lintian maintainers fixed a false positive. N: N: If the override is now unused, please remove it. N: N: This tag is similar to mismatched-override except there a tag could have been silenced if the N: context had matched. N: N: Sometimes, overrides end up not being used because a tag appears only on some architectures. In N: that case, overrides can be equipped with an architecture qualifier. N: N: Please refer to Architecture specific overrides (Section 2.4.3) in the Lintian User's Manual for N: details. N: N: Visibility: info N: Show-Always: yes N: Check: lintian 3. Licenses (lrc): Good 4. Watch file (uscan --force-download): Good 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 6. Reproducible builds (reporotest)[3]: Good 7. Install (No previous installs): Good 8. Upgrade (Over previous installs if any): Good Additional... A. Please could you update 'Standards-Version' in 'debian/control' to 4.7.0 as per Debian policy[4]. This would be nice before sponsoring. Summary... I believe git-credential-oauth is ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. [1] Using pbuilder and sbuild. [2] lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method [4] https://www.debian.org/doc/debian-policy/ Regards Phil -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
