On Sat, 2024-06-15 at 09:39 +1000, Matthew Fernandez wrote: > Control: tags -1 - moreinfo > > On 6/14/24 19:47, Phil Wyett wrote: > > Control: tags -1 + moreinfo > > > > Hi Matthew, > > > > 'rumur' is an extensive package with a lot going on at build time. Some of > > the > > build time tests are skipped due to missing 'xmllint'. Adding > > 'libxml2-utils' as > > a 'Build-Depends' allows the tests to be performed. There maybe reasoning > > why > > this 'Build-Depends' was not added, but only you can let us know that. > > > > Other tests are skipped for a variety of reasons. Maybe you could have an > > audit > > of these and make changes where appropriate? > > Thanks for the review, Phil. I did it this way under the assumption that > time on the buildd machines was expensive, but I think the prevailing > wisdom is actually that letting mistakes slip through to end users is a > worse cost. I’ve done as you suggested and enabled more of the skipped > tests. The main block still skipped are the Uclid tests which depend on > a niche academic tool that is not packaged in Debian. > > While we’re discussing this, Rumur can do some smarter things if an SMT > solver like Z3 is installed. Should I add z3 to Suggests? I’m unsure > about this as Z3 is merely _one_ SMT solver Rumur can use, not _the_ SMT > solver it must use. >
Hi Matthew, Letting mistakes slip through as you say would be worse. Software is getting more complex in a variety of fields/organisations etc. that use Debian. If build times increase because of this the infrastructure team should see this and move/act accordingly to meet new or higher needs. If 'Uclid' is so niche where you believe it is not worthwhile to request its packaging ans support it, that is your decision knowing more about it and your package. That may change in the future, but who knows what the future may bring. Not being required, adding 'z3' as a 'Suggests' would seem appropriate. In 'debian/control'. Could you update to the latest 'Standards-Version' which is 4.7.0[1]. In 'debian/copyright'. I would update the line below. Copyright: 2019 Matthew Fernandez <matthew.fernan...@gmail.com> to Copyright: 2019-2024 Matthew Fernandez <matthew.fernan...@gmail.com> Other than these little things, all is good and if you wish to make these changes, we can then ask a DD to sponsor. [1] Link below. https://www.debian.org/doc/debian-policy/upgrading-checklist.html#version-4-7-0 Regards Phil -- Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
