Cyril Brulebois <[email protected]> (2024-04-10): > Intermediate results based on upstream stable releases: v6.1.80 is good, > v6.1.81 is bad. Still ~200 commits to bisect.
Final results:
kibi@genova:~/hack/linux.git ((cf33e6ca12d81...)|BISECTING)$ git bisect bad
cf33e6ca12d814e1be2263cb76960d0019d7fb94 is the first bad commit
commit cf33e6ca12d814e1be2263cb76960d0019d7fb94
Author: Mike Christie <[email protected]>
Date: Thu Dec 29 13:01:40 2022 -0600
scsi: core: Add struct for args to execution functions
[ Upstream commit d0949565811f0896c1c7e781ab2ad99d34273fdf ]
Move the SCSI execution functions to use a struct for passing in
optional
args. This commit adds the new struct, temporarily converts
scsi_execute()
and scsi_execute_req() ands a new helper, scsi_execute_cmd(), which
takes
the scsi_exec_args struct.
There should be no change in behavior. We no longer allow users to pass
in
any request->rq_flags value, but they were only passing in RQF_PM which
we
do support by allowing users to pass in the BLK_MQ_REQ flags used by
blk_mq_alloc_request().
Subsequent commits will convert scsi_execute() and scsi_execute_req()
users
to the new helpers then remove scsi_execute() and scsi_execute_req().
Signed-off-by: Mike Christie <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: John Garry <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Stable-dep-of: 321da3dc1f3c ("scsi: sd: usb_storage: uas: Access media
prior to querying device properties")
Signed-off-by: Sasha Levin <[email protected]>
drivers/scsi/scsi_lib.c | 52
++++++++++++++++++++++------------------------
include/scsi/scsi_device.h | 51
++++++++++++++++++++++++++++++++-------------
2 files changed, 62 insertions(+), 41 deletions(-)
That's one of the 3 commits suggested by Diederik, good hunch.
I know hindsight is always 100% but “There should be no change in
behavior.”… :D
Of course, since there are companion changes afterwards, it cannot be
simply reverted on top of either v6.1.82 (Debian) or v6.1.84 (upstream).
I'd appreciate if someone could carry the ball through the appropriate
channels upstream.
Cheers,
--
Cyril Brulebois ([email protected]) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
