Bug#1066239: gnome-system-tools: FTBFS: shares-tool.c:113:17: error: implicit declaration of function ‘table_add_share’ [-Werror=implicit-function-declaration]

[Vladimir Petko]

Package: gnome-system-tools
Followup-For: Bug #1066239
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

Would it be possible tot consider the attached patch as a solution to this
issue.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/implicit_declaration.patch: add missing declarations to resolve
    ftbfs (LP: #2060165).


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch 
gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch
--- gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch  
1970-01-01 12:00:00.000000000 +1200
+++ gnome-system-tools-3.0.0/debian/patches/implicit_declaration.patch  
2024-04-04 11:38:40.000000000 +1300
@@ -0,0 +1,29 @@
+Description: add missing declarations
+ Add missing headers and declarations to resolve 
-Werror=implicit-function-declaration.
+Author: Vladimir Petko <vladimir.pe...@canonical.com>
+Bug-Ubuntu: 
https://bugs.launchpad.net/debian/+source/gnome-system-tools/+bug/2060165
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066239
+Forwarded: no
+Last-Update: 2024-04-04
+
+--- a/src/shares/shares-tool.h
++++ b/src/shares/shares-tool.h
+@@ -58,6 +58,7 @@
+ };
+
+ GstSharesTool *gst_shares_tool_new (void);
++GType gst_shares_tool_get_type();
+
+
+ G_END_DECLS
+--- a/src/shares/shares-tool.c
++++ b/src/shares/shares-tool.c
+@@ -23,6 +23,8 @@
+ #include "users-table.h"
+ #include <glib/gi18n.h>
+ #include "gst.h"
++#include "table.h"
++#include "share-settings.h"
+
+ static void gst_shares_tool_class_init (GstSharesToolClass *class);
+ static void gst_shares_tool_init       (GstSharesTool      *tool);
diff -Nru gnome-system-tools-3.0.0/debian/patches/series 
gnome-system-tools-3.0.0/debian/patches/series
--- gnome-system-tools-3.0.0/debian/patches/series      2024-03-31 
19:12:52.000000000 +1300
+++ gnome-system-tools-3.0.0/debian/patches/series      2024-04-04 
11:38:40.000000000 +1300
@@ -23,3 +23,4 @@
 max_group_name_32_chars.patch
 remove_g_thread_init.patch
 70_gst-yelp.patch
+implicit_declaration.patch