On Tuesday, March 26, 2024 9:37:10 A.M. CDT Harald Welte wrote: > Package: libcdk5-dev > Version: 5.0.20230201-3 > Severity: normal > > It used to be the case (for probably more than a decade) that the main cdk.h > file contained in libcdk5-dev is located in /usr/include/cdk/cdk.h > > This is still the case in debian stable as of 5.0.20180306-3 > > However, in currnt unstable (5.0.20230201-3), the location has suddenly > shifted to /usr/include/cdk.h
That is correct. I have only recently taken over cdk maintenance, but here's
what I found in the archives.
Upstream changed the default 12 years ago. The entry in CHANGES [1] for
2012/03/23 includes:
+ add configure --enable-hdr-subdir to control whether cdk.h should
be in /usr/include/cdk for example, or in /usr/include. Make the
default the latter, standard layout.
[1] https://salsa.debian.org/debian/libcdk5/-/blob/debian/CHANGES?
ref_type=heads
Previous maintainer added a patch to install cdk/cdk.h in 2016 [2], about 5
months after the first post-2012 version was uploaded to unstable [3]. I
didn't find any rationale for including the patch.
[2]
https://salsa.debian.org/debian/libcdk5/-/blob/debian/debian/patches/cdk-h-old-place.patch?ref_type=heads
[3] https://tracker.debian.org/pkg/libcdk5/news/?page=2
About four years ago, the previous maintainer removed that patch [4]. You
hadn't seen the effect yet because the packages with that change were only
uploaded to experimental. Again, I failed to find a reason for this change.
[4] https://salsa.debian.org/debian/libcdk5/-/commit/
3ee2ab1f1ecb06c7ff4871469f8661f367ebb6f0
> This is breaking applications like osmo-bsc, which is using the following
> autoconf macro to test for cdk.h presence:
>
> AC_CHECK_HEADERS(cdk/cdk.h, [], AC_MSG_ERROR(Unable to find libcdk))
Given that the upstream change was 12 years ago, I'm genuinely surprised that
sources are still looking for cdk/cdk.h. I can see there's a mix of usages
but at least some sources have adapted [5].
[5] https://github.com/termux/termux-packages/commit/
6279216b943711ef83b6019fcf4bbe832c7a842b
My feeling is that there is benefit to being in harmony with upstream - as I
presume other distros are.
Do you think you could adapt osmo-bsc to the new location?
Best,
-Steve
signature.asc
Description: This is a digitally signed message part.
