Package: backuppc
Version: 2.1.2-4
Severity: minor
Tags: patch
Hi,
some variables that are used for transfer statistics are not properly
initialized and result in incomplete messages if the counters are never
incremented. This seems to affect the tar and samba transfer methods,
the initialization code in my patch was copied from the rsync code.
An example status line:
incr backup 694 complete, 4104 files, bytes, 54 xferErrs ( bad files, bad
shares, 54 other)
^ ^ ^
There are three zeroes missing.
The reported 0 bytes seem to be another bug.
Andreas
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (900, 'testing'), (900, 'stable'), (600, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-1-k7
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages backuppc depends on:
ii adduser 3.87 Add and remove users and groups
ii apache 1.3.34-2 versatile, high-performance HTTP s
ii apache-ssl 1.3.34-2 versatile, high-performance HTTP s
ii apache2-mpm-prefork [apache 2.0.55-4 traditional model for Apache2
ii debconf [debconf-2.0] 1.5.1 Debian configuration management sy
ii dpkg 1.13.19 package maintenance system for Deb
ii exim4 4.44-2 metapackage to ease exim MTA (v4)
ii exim4-daemon-heavy [mail-tr 4.44-2 exim MTA (v4) daemon with extended
ii libarchive-zip-perl 1.16-1 Module for manipulation of ZIP arc
ii libcompress-zlib-perl 1.41-1 Perl module for creation and manip
ii perl [libdigest-md5-perl] 5.8.8-4 Larry Wall's Practical Extraction
ii perl-suid 5.8.8-4 Runs setuid Perl scripts
ii samba-common 3.0.22-1 Samba common files used by both th
ii smbclient 3.0.22-1 a LanManager-like simple client fo
ii tar 1.15.1dfsg-3 GNU tar
ii wwwconfig-common 0.0.45 Debian web auto configuration
backuppc recommends no packages.
-- debconf information:
* backuppc/configuration-note:
* backuppc/add-lines: true
Index: lib/BackupPC/Xfer/Smb.pm
===================================================================
RCS file: /cvsroot/backuppc/BackupPC/lib/BackupPC/Xfer/Smb.pm,v
retrieving revision 1.20
diff -u -r1.20 Smb.pm
--- lib/BackupPC/Xfer/Smb.pm 29 Jan 2006 19:06:18 -0000 1.20
+++ lib/BackupPC/Xfer/Smb.pm 30 May 2006 00:28:52 -0000
@@ -53,6 +53,20 @@
pipeRH => undef,
pipeWH => undef,
badFiles => [],
+
+ #
+ # Various stats
+ #
+ byteCnt => 0,
+ fileCnt => 0,
+ xferErrCnt => 0,
+ xferBadShareCnt => 0,
+ xferBadFileCnt => 0,
+ xferOK => 0,
+
+ #
+ # User's args
+ #
%$args,
}, $class;
Index: lib/BackupPC/Xfer/Tar.pm
===================================================================
RCS file: /cvsroot/backuppc/BackupPC/lib/BackupPC/Xfer/Tar.pm,v
retrieving revision 1.19
diff -u -r1.19 Tar.pm
--- lib/BackupPC/Xfer/Tar.pm 29 Jan 2006 19:06:18 -0000 1.19
+++ lib/BackupPC/Xfer/Tar.pm 30 May 2006 00:28:52 -0000
@@ -53,6 +53,20 @@
pipeRH => undef,
pipeWH => undef,
badFiles => [],
+
+ #
+ # Various stats
+ #
+ byteCnt => 0,
+ fileCnt => 0,
+ xferErrCnt => 0,
+ xferBadShareCnt => 0,
+ xferBadFileCnt => 0,
+ xferOK => 0,
+
+ #
+ # User's args
+ #
%$args,
}, $class;
