Hi Ralf,
I confirmed the bug is present in upstream's configure.in in CVS, and
with the new Debian autoconf package, 2.59.cvs.2006.05.25-1.
On Thu, May 25, 2006, Ralf Wildenhues wrote:
> Yes, the configure.in snippet you posted is weird. Even with
> autoconf-2.59, if you look at a generated config.status file, you will
> see that there are two substitutions for VERSION in config headers
Ah, the first time I read your mail, I overlooked this, and now that I
take the time to read it correctly, I understand the problem.
> > AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
> (Unrelated to the error you're seeing, but nicer anyway:)
> Make this line
> AM_INIT_AUTOMAKE
> only.
> [and] be sure to put
> AUTOMAKE_OPTIONS = 1.6
Ok, I'll forward this as well. The upstream configure.in uses:
AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
AM_CONFIG_HEADER(config.h)
AM_INIT_AUTOMAKE([1.8 dist-bzip2 no-dist-gzip check-news])
(e.g. two automake invocations), and nothing in Makefile.am, so I'll
suggest to simply drop the first one.
> > AC_DEFINE(VERSION, AC_PACKAGE_VERSION, [package version])
> You should be able to just remove this line.
> > AC_SUBST(VERSION)
> And remove this one, too. It's done by Automake in any case.
Indeed, that solved it thanks. I'm going to report that upstream. Do
what you want with my autoconf bug report, I can't decide whether it's
a popular construct that will cause regressions for other upstreams
too, or whether totem was just a very isolated case.
> You should be able to just remove this line. Make sure you don't have
> the Automake option `no-define' set (see above for where Automake
> options may have been set).
As quoted above, it seems not.
> Skimming automake/NEWS it seems these two last quoted lines were added
> to work around an Automake bug fixed in 1.7.3. So if for no other
> reason, you might want to require that version.
Ok.
Thanks for all the fish!
Bye,
--
Loïc Minier <[EMAIL PROTECTED]>
"You can gtk_main_run, but you can't gtk_widget_hide." --danw, 19-jul-04
