Bug#1051329: dictionaries-common: Use of uninitialized value in string eq

[Andreas Schmidt]

Package: dictionaries-common
Version: 1.29.6
Severity: normal
Tags: patch

Dear Maintainer,

when I updated hunspell-de-med, I found this in the log:

*****
Setting up hunspell-de-med (20230905-1) ...
Use of uninitialized value in string eq at
/usr/share/perl5/Debian/DictionariesCommon.pm line 566.
Use of uninitialized value in string eq at
/usr/share/perl5/Debian/DictionariesCommon.pm line 566.

Processing triggers for dictionaries-common (1.29.6) ...
Use of uninitialized value in string eq at
/usr/share/perl5/Debian/DictionariesCommon.pm line 566.
Use of uninitialized value in string eq at
/usr/share/perl5/Debian/DictionariesCommon.pm line 566.
*****


The attached patch should fix this.

Best regards,

Andreas


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.4.0-4-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_CRAP, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dictionaries-common depends on:
ii  cdebconf [debconf-2.0]  0.270
ii  debconf [debconf-2.0]   1.5.82
ii  emacsen-common          3.0.5
ii  libtext-iconv-perl      1.7-8

dictionaries-common recommends no packages.

Versions of packages dictionaries-common suggests:
ii  aspell                0.60.8-6
ii  hunspell              1.7.2+really1.7.2-10
ii  ispell                3.4.05-1
ii  wamerican [wordlist]  2020.12.07-2
ii  wngerman [wordlist]   20161207-11

-- debconf information excluded

--- DictionariesCommon.pm       2023-09-06 10:36:44.641067430 +0200
+++ DictionariesCommon.pm.fixed 2023-09-06 10:48:09.078836355 +0200
@@ -560,10 +560,11 @@
   # Get a list of emacsen and hash names declared in hunspell-info files.
   foreach my $lang ( keys %$main_dicts ){
     my $lang_entries = $main_dicts->{$lang};
-    $main_dicts_emacsen{$lang_entries->{'emacsen-name'}}++
-       if ( defined $lang_entries->{'emacsen-name'} );
-    $main_dicts_hashes{$lang_entries->{'hash-name'}}++
-       unless ( $lang_entries->{'emacsen-name'} eq "english_american" );
+    if ( defined $lang_entries->{'emacsen-name'} ) {
+        $main_dicts_emacsen{$lang_entries->{'emacsen-name'}}++;
+        $main_dicts_hashes{$lang_entries->{'hash-name'}}++
+            unless ( $lang_entries->{'emacsen-name'} eq "english_american" );
+    }
   }
   # Show some debugging code
   dico_debugprint "main-dicts: ". join(', ',sort keys %$main_dicts);