Control: tags -1 + patch

On Mon, 26 Jun 2023 at 13:52:11 +0100, Simon McVittie wrote:
> The latest version of libsdl1.2-compat-dev pulls in libsdl2-dev and
> therefore libsndio-dev, which causes xine-lib-1.2 to fail to build:
> 
> > dh_missing: warning: 
> > usr/lib/x86_64-linux-gnu/xine/plugins/2.11/xineplug_ao_out_sndio.so exists 
> > in debian/tmp but is not installed to anywhere
> > dh_missing: error: missing files, aborting
> 
> Please make the build deterministic: if you don't intend for this plugin
> to be enabled, please configure with --disable-sndio, so that it never
> gets enabled "automagically".

Please see attached. I've verified that this fixes the build when
libsdl1.2-compat-dev is installed, and does not break the build with
"classic" SDL 1.2.

> Doing the same for any other intentionally
> disabled plugins would be a good bit of future-proofing.

I haven't attempted to do this, that seems more like something for a
maintainer to research.

    smcv
>From 34014046004507f3abd8f62d540ecd681317bb37 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Thu, 29 Jun 2023 11:59:07 +0100
Subject: [PATCH] Explicitly disable sndio plugin

Otherwise, when building in a non-minimal environment with libsndio-dev
installed (either directly or because packages like libsdl2-dev depend
on it), the sndio plugin will be enabled automatically, causing
dh_missing to fail because it is not included in any binary package.

Closes: #1039479
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index b82a9cb..977b63a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -32,6 +32,7 @@ CONFIGURE_FLAGS := \
 	--disable-vidix \
 	--enable-directfb \
 	--disable-nosefart \
+	--disable-sndio \
 	$(DEB_BUILD_CONFIG_OPTIONS) \
 	$(shell dpkg-buildflags --export=configure) \
 	LIBMODPLUG_LIBS="$(filter-out -lstdc++ -lm,$(shell pkg-config --libs libmodplug))"
-- 
2.40.1

Reply via email to