* Matt Swift <[EMAIL PROTECTED]> [2006-05-18 14:00]:
> The jack_utils.in_path checks whether the value (a filename) is in
> the operating system environment's $PATH and whether it is
> executable.

Ah, yeah, right.  Thanks.

> The test should be for whether the value is a loadable Python
> Module, which is a different path (which is properly modified to
> include the value of Jack's plugin_path variable).

I don't understand this paragraph.

What's wrong with the following patch:

--- jack_checkopts.py~  2006-05-18 20:44:13.000000000 +0200
+++ jack_checkopts.py   2006-05-18 20:45:48.000000000 +0200
@@ -246,8 +246,9 @@
                 error("No valid ripper found on your system.")
 
     for t in ("ripper", "encoder"):
-        if t in userdef_keys and not jack_utils.in_path(cf[t]["val"]):
-            error("Helper %s '%s' not found on your system." % (t, 
cf[t]["val"]))
+        program = cf[t]["val"].replace("plugin_", "")
+        if t in userdef_keys and not jack_utils.in_path(program):
+            error("Helper %s '%s' not found on your system." % (t, program))
 
     if ('cd_device' not in all_keys and cf["rip_from_device"]["val"] and
         not os.path.exists(cf["cd_device"]["val"])):

-- 
Martin Michlmayr
http://www.cyrius.com/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to