Most of this bug no longer applies, but there is a small issue

The current code (line 783 approx) catches errors from $SORT, but if
the error comes from having zero log files to check i think it will be
a bit confusing.

currently logoutput-sorted would be created as an empty file, but the
call to error() would be a bit confusing

And (once we add a systemd unit) the stderr from sort/sed could end up
in the journal

Think before the call to $SORT logcheck should check if
$TMPDIR/logoutput/ is empty and if so, silently (or perhaps with error
as it seems unlikely to be deliberate) do an exit 0

I think perhaps worth redirecting stderr into
"$TMPDIR/logoutput-sorted" (perhaps needed elsewhere too) but i did
not consider this fully yet

one for post-bookworm

Reply via email to