On Sun, Jan 29, 2023 at 06:35:11AM +0100, Helmut Grohne wrote:
> Source: vile
> Version: 9.8y-1
> Tags: patch upstream
> User: debian-cr...@lists.debian.org
> Usertags: ftcbfs
> 
> vile used to cross build until 9.8x-1. Now it fails. The reasons are not
> entirely clear to me. Here is what I know:
> 
> 1. It checks for setpgrp and getpgrp and these tests turn out to be
>    successful in all cases.
> 2. When cross compiling, it avoids AC_FUNC_SETPGRP and AC_FUNC_GETPGRP
>    even though these macros work fine with cross compiling today.
> 3. For some reason, SETPGRP_VOID and GETPGRP_VOID end up not getting
>    defined during cross compilation. configure isn't very verbose about
>    why.
> 4. If you delete the extra code that tries to support cross building, it
>    just works.
> 
> As such, I recommend skipping deeper investigation and rather deleting

hmm...

> the evidently broken cross compilation support code. Do note that you
> must regenerate configure before upload or enable autoreconf to apply
> this change. I'm attaching the bare configure.in patch for your
> convenience.
> 
> Helmut

> --- vile-9.8y.orig/aclocal.m4
> +++ vile-9.8y/aclocal.m4
> @@ -2932,35 +2932,9 @@
>  dnl messes up the messages...
>  define([CF_KILLPG],
>  [
> -if test "$cross_compiling" = yes ; then
> -     AC_CHECK_FUNC(setpgrp,[
> -     AC_TRY_COMPILE([
> -#ifdef HAVE_UNISTD_H
> -#include <unistd.h>
> -#endif
> -#include <sys/types.h>
> -#include <signal.h>
> -],[
> -    (void) setpgrp();
> -],
> -     [AC_DEFINE(SETPGRP_VOID)])])
> -else
>       AC_FUNC_SETPGRP
> -fi
>  
> -if test "$cross_compiling" = yes ; then
> -     AC_CHECK_FUNC(getpgrp,[
> -     AC_TRY_COMPILE([
> -#ac_includes_default

actually this line is the problem (I made this typo in another
place, and corrected it, but overlooked this occurrence).

The "#" should be "$".  In a quick grep, I've 50 uses of $ac_includes_default,
with this as the only (current) typo.

If there are further issues, the usual approach for reporting bugs is to
include the config.log and config.status to demonstrate the issue.

https://invisible-island.net/personal/bug-reports.html

-- 
Thomas E. Dickey <dic...@invisible-island.net>
https://invisible-island.net

Attachment: signature.asc
Description: PGP signature

Reply via email to