Bug#1026927: needrestart -b on AMD processors complains of perl uninitialized variable

[Patrick Matthäi]

Hey

Am 24.12.22 um 02:25 schrieb George Robbert:

Package: needrestart
Version: 3.5-4+deb11u2
Severity: normal

Dear Maintainer,

When running 'needrestart -b' on an AMD system, I get the following
uninitialized variable warning.  It also does not report the expected
microcode version (NEEDRESTART-UCEXP).  See output: section below for
example output of needrestart -b.

Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string 
at /usr/sbin/needrestart line 904.

This perl warning disappears when adding the -v option (needrestart -b -v),
and the correct value is reported for NEEDRESTART-UCEXP.

The processor, in this system, is:

     vendor_id       : AuthenticAMD
     cpu family      : 18
     model           : 1
     model name      : AMD A4-3400 APU with Radeon(tm) HD Graphics
     stepping        : 0
     microcode       : 0x3000027



It looks to me like the problem is that line 182 of
/usr/share/perl5/NeedRestart/uCode/AMD.pm ends in a comma (,) instead
of a semicolon (;).  This means that assignment is subsumed into the
next line which is under if ($debug).

See the attached patch.

Thanks for your investigation. I have tested it on my (sid/unstable) AMD notebook and I can reproduce your issue with needrestart from stable. But your patch does not produce another result for me. Are you sure, that you didnt changed something else?

OpenPGP_0x12D9B04A90CBD8E4.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature