On 2023-01-05, Christopher Obbard wrote: > On Thu, 2023-01-05 at 13:21 -0300, Walter Lozano wrote: >> Thank you for your help here! I also did some testing, and everything >> looks OK. The only thing to mention is that the the script >> u-boot-install-rockchip does not auto detect my board. >> >> The case statement is >> ``` >> "Radxa ROCK Pi 4") >> TARGET="/usr/lib/u-boot/rock-pi-4-rk3399" >> ``` > > Ah, good catch! > > For compatiblity with mainline (debian) kernel, that line should > probably be updated to: > > "Radxa ROCK Pi 4A"|"Radxa ROCK Pi 4A+"|"Radxa ROCK Pi > 4B"|"Radxa ROCK Pi 4B+") > > > The Radxa kernel[1] 4.14 branches use "ROCK PI 4A" and "ROCK PI 4B", we > could add those in if we really wanted to. The 5.10 based kernels use > devicetrees based on mainline, so are unaffected.
I would definitely be amenable to such a patch, although probably best in a separate bug report and/or merge request. Could even use some wildcards, if appropriate. live well, vagrant
signature.asc
Description: PGP signature
