Source: mp3guessenc Version: 0.27.5+dfsg.1-1 Severity: serious Tags: patch Justification: breaks autopkgtests
Hi, GNU grep 3.8 officially deprecates egrep and fgrep, and those two commands now issue a deprecation message on stderr [1]. The autopkgtests of mp3guessenc use fgrep, and while they still work fine, the extra messages on stderr are considered by default a failure, and thus the tests are marked as such. While autopkgtest has a "allow-stderr" restriction to not consider stderr output as failure in case it is expected, I think the better solution here is simply to switch away from fgrep to grep -F. This works fine with grep 3.8 and any older version. Patch attached for this. [1] https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html Thanks, -- Pino
diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/changelog mp3guessenc-0.27.5+dfsg.1/debian/changelog --- mp3guessenc-0.27.5+dfsg.1/debian/changelog 2020-09-20 21:50:00.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/changelog 2022-09-07 08:12:34.000000000 +0200 @@ -1,3 +1,12 @@ +mp3guessenc (0.27.5+dfsg.1-2) UNRELEASED; urgency=medium + + [ Pino Toscano ] + * Switch from "fgrep" to "grep -F" in autopkgtests, as the former is + officially deprecated since grep 3.8, writing a deprecation message on + stderr that is considered as autopkgtest failure. + + -- Peter Blackman <pe...@pblackman.plus.com> Wed, 07 Sep 2022 08:12:34 +0200 + mp3guessenc (0.27.5+dfsg.1-1) unstable; urgency=medium * New upstream version diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/a mp3guessenc-0.27.5+dfsg.1/debian/tests/a --- mp3guessenc-0.27.5+dfsg.1/debian/tests/a 2020-07-16 10:49:55.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/a 2022-09-07 08:12:13.000000000 +0200 @@ -6,7 +6,7 @@ mp3guessenc -a debian/flush.mp3 > a.tmp set -e # -fgrep 291 a.tmp +grep -F 291 a.tmp # rm a.tmp diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/f mp3guessenc-0.27.5+dfsg.1/debian/tests/f --- mp3guessenc-0.27.5+dfsg.1/debian/tests/f 2020-07-16 10:43:15.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/f 2022-09-07 08:12:13.000000000 +0200 @@ -6,8 +6,8 @@ mp3guessenc -f debian/flush.mp3 > f.tmp set -e # -fgrep "48 kbps" f.tmp -fgrep 550 f.tmp +grep -F "48 kbps" f.tmp +grep -F 550 f.tmp # rm f.tmp diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/i mp3guessenc-0.27.5+dfsg.1/debian/tests/i --- mp3guessenc-0.27.5+dfsg.1/debian/tests/i 2020-07-16 10:48:58.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/i 2022-09-07 08:12:13.000000000 +0200 @@ -6,8 +6,8 @@ mp3guessenc -i debian/flush.mp3 > i.tmp set -e # -fgrep 2020 i.tmp -fgrep Ambient i.tmp +grep -F 2020 i.tmp +grep -F Ambient i.tmp # rm i.tmp diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/m mp3guessenc-0.27.5+dfsg.1/debian/tests/m --- mp3guessenc-0.27.5+dfsg.1/debian/tests/m 2020-07-16 10:44:39.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/m 2022-09-07 08:12:13.000000000 +0200 @@ -6,8 +6,8 @@ mp3guessenc -f debian/flush.mp3 > f.tmp set -e # -fgrep "48 kbps" f.tmp -fgrep 550 f.tmp +grep -F "48 kbps" f.tmp +grep -F 550 f.tmp # rm f.tmp diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/n mp3guessenc-0.27.5+dfsg.1/debian/tests/n --- mp3guessenc-0.27.5+dfsg.1/debian/tests/n 2020-07-16 11:08:27.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/n 2022-09-07 08:12:13.000000000 +0200 @@ -11,7 +11,7 @@ fi set -e # -fgrep FhG n.tmp +grep -F FhG n.tmp # rm n.tmp diff -Nru mp3guessenc-0.27.5+dfsg.1/debian/tests/s mp3guessenc-0.27.5+dfsg.1/debian/tests/s --- mp3guessenc-0.27.5+dfsg.1/debian/tests/s 2020-07-16 10:51:16.000000000 +0200 +++ mp3guessenc-0.27.5+dfsg.1/debian/tests/s 2022-09-07 08:12:13.000000000 +0200 @@ -6,7 +6,7 @@ mp3guessenc -s debian/flush.mp3 > s.tmp set -e # -fgrep FhG s.tmp +grep -F FhG s.tmp # rm s.tmp
