On 21 August 2022 at 22:27, Bo YU wrote:
| Hi,
| On Sun, Aug 21, 2022 at 09:14:14AM -0500, Dirk Eddelbuettel wrote:
| >| >
| >| >So what is the proper architecture name for riscv64, and please remind me
| >| >what the best way to determine it is (uname -m ? Or uname -p ? Or uname
-i ?)
| >|
| >| There is only usefully for $(uname -m) for riscv64 hadreware now.
| >|
| >| vimer@unmatched:~/build/08/33_gridengine$ uname -m
| >| riscv64
| >| vimer@unmatched:~/build/08/33_gridengine$ uname -p
| >| unknown
| >| vimer@unmatched:~/build/08/33_gridengine$ uname -i
| >| unknown
| >
| >Thanks that should help.
| >
| >| BTW, I saw the solution is ok also.
| >|
| >| ifeq ($(DEB_HOST_ARCH),riscv64)
| >| # do something
| >| endif
| >|
| >| Is it ok for our case?
| >
| >If and when one uses debian/rules (or alike, yes). But I think I put it 'up
| >one level' into configure.ac and that may not have the Debian vars set
| >(unless called from debian/rules I suppose).
|
| Oh, yes, It is applied to debian/rules and I forget to mention it.:)
No worries :) Do you have easy-enough access to the platform? Could you
test this diff (and then also run 'autoconf' to regenerate 'configure'; else
I can send you a longer diff including it). And of course remove what we had
added to src/Makevars.in 'by hand'.
| modified configure.ac
@@ -153,6 +153,13 @@ if test x"${uname}" = x"Darwin" -a x"${machine}" =
x"x86_64"; then
AC_MSG_RESULT([${CXX17_MACOS}])
fi
+## Take care of riscv64 machines and need for -latomic
+if test x"${uname}" = x"riscv64"; then
+ AC_MSG_CHECKING([for riscv64 linker adjustment])
+ CXX17_MACOS="-mmacosx-version-min=10.14"
+ TILEDB_LIBS="${TILEDB_LIBS} -latomic"
+ AC_MSG_RESULT([${TILEDB_LIBS}])
+fi
## -- Part 3: Check for TileDB
--------------------------------------------------
##
Dirk
--
dirk.eddelbuettel.com | @eddelbuettel | [email protected]
