Package: gitlab-ci-multi-runner
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu kinetic ubuntu-patch
Hi Dmitry,
The gitlab-ci-multi-runner package fails to build from source in Ubuntu
because unlike in Debian, certain -dev packages required to build don't
happen to be pulled in as indirect build-dependencies:
[...]
src/gitlab.com/gitlab-org/gitlab-runner/helpers/container/services/services.go:8
:2: cannot find package "github.com/docker/distribution/reference" in any of:
/<<PKGBUILDDIR>>/_build/src/gitlab.com/gitlab-org/gitlab-runner/vendor/g
ithub.com/docker/distribution/reference (vendor tree)
/usr/lib/go-1.18/src/github.com/docker/distribution/reference (from $GOR
OOT)
/<<PKGBUILDDIR>>/_build/src/github.com/docker/distribution/reference (fr
om $GOPATH)
src/gitlab.com/gitlab-org/gitlab-runner/vendor/k8s.io/api/core/v1/generated.pb.g
o:230:2: cannot find package "github.com/gogo/protobuf/proto" in any of:
/<<PKGBUILDDIR>>/_build/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/gogo/protobuf/proto
(vendor tree)
/usr/lib/go-1.18/src/github.com/gogo/protobuf/proto (from $GOROOT)
/<<PKGBUILDDIR>>/_build/src/github.com/gogo/protobuf/proto (from
$GOPATH)
src/gitlab.com/gitlab-org/gitlab-runner/vendor/k8s.io/api/core/v1/generated.pb.go:242:2:
cannot find package "github.com/gogo/protobuf/sortkeys" in any of:
/<<PKGBUILDDIR>>/_build/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/gogo/protobuf/sortkeys
(vendor tree)
/usr/lib/go-1.18/src/github.com/gogo/protobuf/sortkeys (from $GOROOT)
/<<PKGBUILDDIR>>/_build/src/github.com/gogo/protobuf/sortkeys (from
$GOPATH)
src/gitlab.com/gitlab-org/gitlab-runner/session/session.go:9:2: cannot find
package "github.com/gorilla/websocket" in any of:
/<<PKGBUILDDIR>>/_build/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/gorilla/websocket
(vendor tree)
/usr/lib/go-1.18/src/github.com/gorilla/websocket (from $GOROOT)
/<<PKGBUILDDIR>>/_build/src/github.com/gorilla/websocket (from $GOPATH)
[...]
(https://launchpad.net/ubuntu/+source/gitlab-ci-multi-runner/13.3.1+dfsg-4/+build/23574022)
It is correct for gitlab-ci-multi-runner to declare build-dependencies on
each of these go modules since its source code uses them directly.
Please see the attached patch.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru gitlab-ci-multi-runner-13.3.1+dfsg/debian/control
gitlab-ci-multi-runner-13.3.1+dfsg/debian/control
--- gitlab-ci-multi-runner-13.3.1+dfsg/debian/control 2021-01-17
03:52:33.000000000 -0800
+++ gitlab-ci-multi-runner-13.3.1+dfsg/debian/control 2022-07-05
13:10:33.000000000 -0700
@@ -13,7 +13,7 @@
,golang-github-burntsushi-toml-dev
,golang-github-docker-docker-credential-helpers-dev (>= 0.5.0~)
,golang-github-docker-docker-dev (>= 20.10.0~beta1)
-# ,golang-github-docker-distribution-dev
+ ,golang-github-docker-distribution-dev
,golang-github-docker-go-connections-dev (>= 0.4.0~)
,golang-github-docker-go-units-dev
,golang-github-docker-spdystream-dev
@@ -24,12 +24,14 @@
,golang-github-ghodss-yaml-dev
,golang-github-gofrs-flock-dev
,golang-github-go-ini-ini-dev
+ ,golang-github-gogo-protobuf-dev
,golang-github-googleapis-gnostic-dev
,golang-github-google-gofuzz-dev
,golang-github-gophercloud-gophercloud-dev
,golang-github-gorhill-cronexpr-dev
,golang-github-gorilla-context-dev
,golang-github-gorilla-mux-dev
+ ,golang-github-gorilla-websocket-dev
,golang-github-hashicorp-go-version-dev
,golang-github-howeyc-gopass-dev
,golang-github-imdario-mergo-dev
