Control: reopen -1 Thanks for the quick turnaround, unfortunately it seems my fix is insufficient. It worked in a test build only because the environment I was testing on returned armv8l for platform instead of armv7. On a real armv7 system, the additional -march argument is unfortunately added to the commandline BEFORE the one from the upstream build system, which overrides it. So surgery on the upstream build system is required.
On Tue, Apr 12, 2022 at 11:39:09PM -0700, Steve Langasek wrote: > Package: ck > Version: 0.7.1-6 > Severity: important > Tags: patch > User: [email protected] > Usertags: origin-ubuntu jammy ubuntu-patch > > Hi Daniel, > > In Ubuntu, ck fails to build on armhf because the upstream build system is > passing an explicit -march option that is no longer correct because it does > not include floating-point support which is implicit in armhf: > > [...] > /usr/bin/cc -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99 > -pedantic -Wall -W -Wundef -Wendif-labels -Wshadow -Wpointer-arith > -Wcast-align -Wcast-qual -Wwrite-strings -Wstrict-prototypes > -Wmissing-prototypes -Wnested-externs -Winline -Wdisabled-optimization > -fstrict-aliasing -O2 -pipe -Wno-parentheses -g -O2 > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat > -Werror=format-security -march=armv7-a -fPIC -D_XOPEN_SOURCE=600 > -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99 -pedantic -Wall -W -Wundef > -Wendif-labels -Wshadow -Wpointer-arith -Wcast-align -Wcast-qual > -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs > -Winline -Wdisabled-optimization -fstrict-aliasing -O2 -pipe -Wno-parentheses > -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat > -Werror=format-security -march=armv7-a -fPIC -I/<<PKGBUILDDIR>>/include > -I/<<PKGBUILDDIR>>/include -D__arm__ -c -o > /<<PKGBUILDDIR>>/src/ck_barrier_tournament.o > /<<PKGBUILDDIR>>/src/ck_barrier_tournament.c > cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU > cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU > [...] > > (https://launchpad.net/ubuntu/+source/ck/0.7.1-6/+build/22357550) > > I have not verified whether this build failure exists with the current > toolchain in Debian, therefore I am not marking this as a serious bug; > however, I expect that if this toolchain change has not yet happened in > Debian, it will happen soon. > > I have applied the attached patch in Ubuntu to let ck build by choosing an > appropriate cpu target of -march=armv7-a+fp. Please consider applying it in > Debian as well. Alternatively, upstream could just not override the -march > at all and trust the compiler defaults. > > Thanks, > -- > Steve Langasek Give me a lever long enough and a Free OS > Debian Developer to set it on, and I can move the world. > Ubuntu Developer https://www.debian.org/ > [email protected] [email protected] -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ [email protected] [email protected]
signature.asc
Description: PGP signature
