clone 365552 -1
reassign -1 boa 0.94.14rc20-1.2
retitle -1 boa does not set valid SERVER_NAME & SERVER_PORT
severity -1 important
tags -1 patch
thanks

On Mon, 1 May 2006, Martintxo wrote:

> I tested dwww 1.9.92 from experimental. I install it in a Sarge
> environment. For made it, I touch the debian/control file, for change in
> the Depends line: menu (>= 2.1.27) for menu (>= 2.1.24) (that is the

This is because menu 2.1.27 adds support for the `removecommand'
keyword. However, I've just checked that 2.1.24 ignores unknown keywords
in menu-method files, so I'll lower the menu dependency in the next
version of dwww.

> dwww-1.9.92 works so well in Sarge with apache-1.3.33. I test a little bit
> it and no find bugs. But with boa-0.94.14rc20-1.2 like web server dwww has
> a little bug in the 'Other documents' link.

Yeah, I can see it - the dir URI does not end with '/', will be fixed
soon in dwww.

> If you made a search (search emelfm package, for exemp.) and made click in
> the 'Other documents' link, with Mozilla it says that "don't find :0"
> (badly translated from my spanish localization), and with Dillo "ERROR: dns
> can't solve".

And this is the boa bug. When the URI for directory does not end with
'/', dwww makes use of the $SERVER_NAME and $SERVER_PORT CGI variables 
to send redirect to proper location (ending with the slash character).
However boa does not set them correctly (SERVER_NAME is empty,
SERVER_PORT is 0).

The bug seems to be fixed by the upstream in boa 0.94.14rc21. I'm
attaching a simple patch based on this version.
 
> The link URL is
> http://localhost/cgi-bin/dwww/usr/share/doc/emelfm?type=dir, and it works
> well with the Apache web server. But for it to works with Boa, the URL must

In this case, with boa, dwww will redirect the browser to
http://:0/cgi-bin/dwww/usr/share/doc/emelfm/?type=dir
which obviously won't work.

Best Regards,
robert

diff -Nur boa-0.94.14rc20.old/src/boa.c boa-0.94.14rc20/src/boa.c
--- boa-0.94.14rc20.old/src/boa.c       2006-01-01 00:01:59.000000000 +0100
+++ boa-0.94.14rc20/src/boa.c   2006-05-01 10:24:36.000000000 +0200
@@ -84,8 +84,8 @@
 
     parse_commandline(argc,argv);
     fixup_server_root();
-    create_common_env();
     read_config_files();
+    create_common_env();
     open_logs();
     server_s = create_server_socket();
     init_signals();

Reply via email to