Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: lafo...@gnumonks.org
Hi,
Due to some changes in Python that upstream failed to take into account,
django-allauth 0.44.0+ds-1 fails to work with the OpenID auth method.
The fix in itself is a simple patch replacing the call to a now
nonexistent function of the base64 module by a call to another which
replaces it.
The debdiff is attached, and the fix already is in unstable and testing.
The other changes are the gbp.conf git-debian-branch variable and the
addition of a Forwarded: tag in two patches to make lintian happier.
Additional information:
[ Impact ]
Without this upload, openid auth mechanism can't work. In bullseye,
django-allauth is mostly used by mailman3, so the scope of impacted
users is mailman3 users.
[ Tests ]
There is no test covering the code, as upstream did not provide unit
tests or functional tests. I ran pyflakes3 on it.
[ Risks ]
Code change is trivial
[ Checklist ]
[x] *all* changes are documented in the d/changelog
- Except the gbp.conf change as it is not even a packaging change.
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Other info ]
Thanks for your work <3
diff -Nru django-allauth-0.44.0+ds/debian/changelog
django-allauth-0.44.0+ds/debian/changelog
--- django-allauth-0.44.0+ds/debian/changelog 2021-01-18 02:25:56.000000000
+0100
+++ django-allauth-0.44.0+ds/debian/changelog 2022-01-22 13:55:10.000000000
+0100
@@ -1,3 +1,11 @@
+django-allauth (0.44.0+ds-1+deb11u1) bullseye; urgency=medium
+
+ * Import from 0.47.0-1 the patch to fix OpenID failures.
+ (Closes: #1003069)
+ * Disable forwarding for two patches
+
+ -- Pierre-Elliott Bécue <p...@debian.org> Sat, 22 Jan 2022 13:55:10 +0100
+
django-allauth (0.44.0+ds-1) unstable; urgency=medium
[ Ondřej Nový ]
diff -Nru django-allauth-0.44.0+ds/debian/gbp.conf
django-allauth-0.44.0+ds/debian/gbp.conf
--- django-allauth-0.44.0+ds/debian/gbp.conf 2021-01-18 02:25:56.000000000
+0100
+++ django-allauth-0.44.0+ds/debian/gbp.conf 2022-01-22 13:51:42.000000000
+0100
@@ -1,2 +1,3 @@
[DEFAULT]
pristine-tar = True
+debian-branch = debian/bullseye
diff -Nru
django-allauth-0.44.0+ds/debian/patches/0001-Remove-all-privacy-breack-links-from-documentation.patch
django-allauth-0.44.0+ds/debian/patches/0001-Remove-all-privacy-breack-links-from-documentation.patch
---
django-allauth-0.44.0+ds/debian/patches/0001-Remove-all-privacy-breack-links-from-documentation.patch
2021-01-18 02:25:56.000000000 +0100
+++
django-allauth-0.44.0+ds/debian/patches/0001-Remove-all-privacy-breack-links-from-documentation.patch
2022-01-22 13:54:22.000000000 +0100
@@ -2,6 +2,8 @@
Date: Tue, 12 Dec 2017 10:35:57 +0100
Subject: Remove all privacy breack links from documentation
+Forwarded: not-needed
+
---
README.rst | 22 ----------------------
1 file changed, 22 deletions(-)
diff -Nru
django-allauth-0.44.0+ds/debian/patches/0003-fix-openid-Use-decodebytes-instead-of-decodestring.patch
django-allauth-0.44.0+ds/debian/patches/0003-fix-openid-Use-decodebytes-instead-of-decodestring.patch
---
django-allauth-0.44.0+ds/debian/patches/0003-fix-openid-Use-decodebytes-instead-of-decodestring.patch
1970-01-01 01:00:00.000000000 +0100
+++
django-allauth-0.44.0+ds/debian/patches/0003-fix-openid-Use-decodebytes-instead-of-decodestring.patch
2022-01-22 13:55:01.000000000 +0100
@@ -0,0 +1,36 @@
+From: Karthikeyan Singaravelan <tir.kar...@gmail.com>
+Date: Thu, 20 Jan 2022 00:25:36 +0100
+Subject: fix(openid): Use decodebytes instead of decodestring
+Applied-Upstream:
https://github.com/pennersr/django-allauth/commit/425dc774fb5d032204b92f0870c3802202259ad3
+
+Co-authored-by: Raymond Penners <raymond.penn...@intenct.nl>
+---
+ AUTHORS | 1 +
+ allauth/socialaccount/providers/openid/utils.py | 2 +-
+ 2 files changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/AUTHORS b/AUTHORS
+index 4e2ffb6..3fd282b 100644
+--- a/AUTHORS
++++ b/AUTHORS
+@@ -90,6 +90,7 @@ Joshua Sorenson
+ Julen Ruiz Aizpuru
+ Justin Michalicek
+ Justin Pogrob
++Karthikeyan Singaravelan
+ Kevin Dice
+ Koichi Harakawa
+ Lee Semel
+diff --git a/allauth/socialaccount/providers/openid/utils.py
b/allauth/socialaccount/providers/openid/utils.py
+index cf32213..bfd766c 100644
+--- a/allauth/socialaccount/providers/openid/utils.py
++++ b/allauth/socialaccount/providers/openid/utils.py
+@@ -102,7 +102,7 @@ class DBOpenIDStore(OIDStore):
+ for stored_assoc in stored_assocs:
+ assoc = OIDAssociation(
+ stored_assoc.handle,
+- base64.decodestring(stored_assoc.secret.encode("utf-8")),
++ base64.decodebytes(stored_assoc.secret.encode("utf-8")),
+ stored_assoc.issued,
+ stored_assoc.lifetime,
+ stored_assoc.assoc_type,
diff -Nru django-allauth-0.44.0+ds/debian/patches/series
django-allauth-0.44.0+ds/debian/patches/series
--- django-allauth-0.44.0+ds/debian/patches/series 2021-01-18
02:25:56.000000000 +0100
+++ django-allauth-0.44.0+ds/debian/patches/series 2022-01-22
13:44:45.000000000 +0100
@@ -1,2 +1,3 @@
0001-Remove-all-privacy-breack-links-from-documentation.patch
0002-Fixes-wrongly-encoded-characters-in-some-.po-files.patch
+0003-fix-openid-Use-decodebytes-instead-of-decodestring.patch
