Package: ntpsec
Version: 1.2.1+dfsg1-2
Severity: normal

Hey.

I wondered the following:


1) In the systemd unit file, it's commented:
# Specifying -g on the command line allows ntpd to make large adjustments to
# the clock on boot.  However, if Restart=yes is set, a malicious (or broken)
# server could send the incorrect time, trip the panic threshold, and when
# ntpd restarts, serve it the incorrect time (which would be accepted).

but in /etc/default/ntpsec there's nevertheless:
NTPD_OPTS="-g -N"
which is used.

Shouldn't -g be removed?



2) Also in /etc/default/ntpsec, per default IGNORE_DHCP is "".
Shouldn't that be set to yes, so that per default a malicious DHCP server
couldn't add it's own possible rogue servers?



3) The legacy ntp.conf used:
restrict -4 default kod notrap nomodify nopeer noquery limited
restrict -6 default kod notrap nomodify nopeer noquery limited

okay, notrap is gone, but they still had one entry for -4 and one for -6.

That's similar what upstream does in their examples:
https://gitlab.com/NTPsec/ntpsec/-/blob/master/etc/ntp.d/use-no-remote-configuration
restrict default kod limited nomodify nopeer noquery
restrict -6 default kod limited nomodify nopeer noquery

Sure that one entry would account for all possible (v4/v6) hosts in the default
entry?



4) Also the legacy ntp.conf used in addition:
restrict source notrap nomodify noquery

Am I right, that this is no longer needed because of the changed meaning of 
nopeer?



Thanks :-)

Chris.

Reply via email to