Package: xclips
Version: 6.21-6
Severity: grave
Tags: patch
Justification: renders package unusable
The current transition to X11R7.0, and in particular out of /usr/X11R6,
poses two problems for (x)clips:
1) It FTBFS because it inappropriately assumes that autoconf will set
x_libraries to a non-empty string.
2) It explicitly installs xclips into /usr/X11R6/bin. (Policy already
discouraged this practice, with a reluctant exception for packages
that use imake, and recent versions of x11-common ship /usr/X11R6/bin
as a symlink [to /usr/bin] and conflict outright with packages such
as existing versions of xclips that try to put anything there.)
The attached patch addresses both issues; could you please apply it,
or at least authorize an NMU?
Thanks!
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable'), (300, 'unstable'), (300,
'testing')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16.9
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages xclips depends on:
ii clips-common 6.21-6.0 CLIPS common files and examples
ii libc6 2.3.6-7 GNU C Library: Shared libraries
ii libclips 6.21-6.0 CLIPS shared libraries
ii libice6 1:1.0.0-3 X11 Inter-Client Exchange library
ii libsm6 1:1.0.0-4 X11 Session Management library
ii libx11-6 2:1.0.0-6 X11 client-side library
ii libxaw7 1:1.0.1-5 X11 Athena Widget library
ii libxext6 1:1.0.0-4 X11 miscellaneous extension librar
ii libxmu6 1:1.0.1-3 X11 miscellaneous utility library
ii libxt6 1:1.0.0-4 X11 toolkit intrinsics library
xclips recommends no packages.
-- no debconf information
diff -u clips-6.21.orig/clipssrc/configure.in clips-6.21/clipssrc/configure.in
--- clips-6.21.orig/clipssrc/configure.in
+++ clips-6.21/clipssrc/configure.in
@@ -77,20 +77,20 @@
AC_CHECK_LIB(socket,socket)
AC_PATH_X
AC_SUBST(x_libraries)
- LDFLAGS="$LDFLAGS -L$x_libraries"
+ LDFLAGS="$LDFLAGS ${x_libraries:+-L$x_libraries}"
dnl WARNING: library search ORDER is very important !!!!
- AC_CHECK_LIB(X11,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xext,main,,,-L${x_libraries})
- AC_CHECK_LIB(ICE,main,,,-L${x_libraries})
- AC_CHECK_LIB(SM,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xt,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xmu,main,,,-L${x_libraries})
+ AC_CHECK_LIB(X11,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xext,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(ICE,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(SM,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xt,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xmu,main,,,${x_libraries:+-L$x_libraries})
AC_CHECK_LIB(Xaw3d, main,,
AC_CHECK_LIB(Xaw, main,,,
- -L${x_libraries}),
- -L${x_libraries})
+ ${x_libraries:+-L$x_libraries}),
+ ${x_libraries:+-L$x_libraries})
fi
dnl ----------------------------
diff -u clips-6.21.orig/clipssrc/configure clips-6.21/clipssrc/configure
--- clips-6.21.orig/clipssrc/configure
+++ clips-6.21/clipssrc/configure
@@ -1533,7 +1533,7 @@
fi
- LDFLAGS="$LDFLAGS -L$x_libraries"
+ LDFLAGS="$LDFLAGS ${x_libraries:+-L$x_libraries}"
echo $ac_n "checking for main in -lX11""... $ac_c" 1>&6
@@ -1543,7 +1543,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lX11 -L${x_libraries} $LIBS"
+LIBS="-lX11 ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1549 "configure"
#include "confdefs.h"
@@ -1586,7 +1586,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXext -L${x_libraries} $LIBS"
+LIBS="-lXext ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1592 "configure"
#include "confdefs.h"
@@ -1629,7 +1629,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lICE -L${x_libraries} $LIBS"
+LIBS="-lICE ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1635 "configure"
#include "confdefs.h"
@@ -1672,7 +1672,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lSM -L${x_libraries} $LIBS"
+LIBS="-lSM ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1678 "configure"
#include "confdefs.h"
@@ -1715,7 +1715,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXt -L${x_libraries} $LIBS"
+LIBS="-lXt ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1721 "configure"
#include "confdefs.h"
@@ -1758,7 +1758,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXmu -L${x_libraries} $LIBS"
+LIBS="-lXmu ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1764 "configure"
#include "confdefs.h"
@@ -1801,7 +1801,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXaw3d -L${x_libraries} $LIBS"
+LIBS="-lXaw3d ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1807 "configure"
#include "confdefs.h"
@@ -1842,7 +1842,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXaw -L${x_libraries} $LIBS"
+LIBS="-lXaw ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1848 "configure"
#include "confdefs.h"
diff -u clips-6.21.orig/x-prjct/xinterface/configure.in clips-6.21/x-prjct/xinterface/configure.in
--- clips-6.21.orig/x-prjct/xinterface/configure.in
+++ clips-6.21/x-prjct/xinterface/configure.in
@@ -71,20 +71,20 @@
AC_CHECK_LIB(socket,socket)
AC_PATH_X
AC_SUBST(x_libraries)
- LDFLAGS="$LDFLAGS -L$x_libraries"
+ LDFLAGS="$LDFLAGS ${x_libraries:+-L$x_libraries}"
dnl WARNING: library search ORDER is very important !!!!
- AC_CHECK_LIB(X11,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xext,main,,,-L${x_libraries})
- AC_CHECK_LIB(ICE,main,,,-L${x_libraries})
- AC_CHECK_LIB(SM,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xt,main,,,-L${x_libraries})
- AC_CHECK_LIB(Xmu,main,,,-L${x_libraries})
+ AC_CHECK_LIB(X11,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xext,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(ICE,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(SM,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xt,main,,,${x_libraries:+-L$x_libraries})
+ AC_CHECK_LIB(Xmu,main,,,${x_libraries:+-L$x_libraries})
AC_CHECK_LIB(Xaw3d, main,,
AC_CHECK_LIB(Xaw, main,,,
- -L${x_libraries}),
- -L${x_libraries})
+ ${x_libraries:+-L$x_libraries}),
+ ${x_libraries:+-L$x_libraries})
fi
dnl ----------------------------
diff -u clips-6.21.orig/x-prjct/xinterface/configure clips-6.21/x-prjct/xinterface/configure
--- clips-6.21.orig/x-prjct/xinterface/configure
+++ clips-6.21/x-prjct/xinterface/configure
@@ -1496,7 +1496,7 @@
fi
- LDFLAGS="$LDFLAGS -L$x_libraries"
+ LDFLAGS="$LDFLAGS ${x_libraries:+-L$x_libraries}"
echo $ac_n "checking for main in -lX11""... $ac_c" 1>&6
@@ -1506,7 +1506,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lX11 -L${x_libraries} $LIBS"
+LIBS="-lX11 ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1512 "configure"
#include "confdefs.h"
@@ -1549,7 +1549,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXext -L${x_libraries} $LIBS"
+LIBS="-lXext ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1555 "configure"
#include "confdefs.h"
@@ -1592,7 +1592,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lICE -L${x_libraries} $LIBS"
+LIBS="-lICE ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1598 "configure"
#include "confdefs.h"
@@ -1635,7 +1635,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lSM -L${x_libraries} $LIBS"
+LIBS="-lSM ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1641 "configure"
#include "confdefs.h"
@@ -1678,7 +1678,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXt -L${x_libraries} $LIBS"
+LIBS="-lXt ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1684 "configure"
#include "confdefs.h"
@@ -1721,7 +1721,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXmu -L${x_libraries} $LIBS"
+LIBS="-lXmu ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1727 "configure"
#include "confdefs.h"
@@ -1764,7 +1764,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXaw3d -L${x_libraries} $LIBS"
+LIBS="-lXaw3d ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1770 "configure"
#include "confdefs.h"
@@ -1805,7 +1805,7 @@
echo $ac_n "(cached) $ac_c" 1>&6
else
ac_save_LIBS="$LIBS"
-LIBS="-lXaw -L${x_libraries} $LIBS"
+LIBS="-lXaw ${x_libraries:+-L$x_libraries} $LIBS"
cat > conftest.$ac_ext <<EOF
#line 1811 "configure"
#include "confdefs.h"
diff -u clips-6.21.orig/debian/rules clips-6.21/debian/rules
--- clips-6.21.orig/debian/rules
+++ clips-6.21/debian/rules
@@ -36,8 +36,7 @@
dh_testdir
cd x-prjct/xinterface && sh ./configure \
--prefix=$(CURDIR)/debian/clips/usr/ \
- --enable-xclips --bindir=\$${exec_prefix}/X11R6/bin \
- --with-clipssrc=../../clipssrc/
+ --enable-xclips --with-clipssrc=../../clipssrc/
cd clipssrc && sh ./configure --prefix=$(CURDIR)/debian/xclips/usr
touch configure-x
diff -u clips-6.21.orig/debian/xclips.dirs clips-6.21/debian/xclips.dirs
--- clips-6.21.orig/debian/xclips.dirs
+++ clips-6.21/debian/xclips.dirs
@@ -1,4 +1,4 @@
-usr/X11R6/bin/
+usr/bin
usr/share/doc/xclips
usr/share/clips
etc/X11/app-defaults
