Package: timidity Version: 2.14.0-8 I have been working on updating Fedora's timidity packages to the 2.15.0 release (which is actually quite old) and checking Debian's patches as part of this.
Patch 0005-fix-drum-panning.patch, which fixes: https://bugs.debian.org/536252 Stood out to me. I've been looking at: 0005-fix-drum-panning.patch and I believe that this patch is wrong. In most cases bank->tone[prog].pan is set to -1 (which gets checked in the if above the modified line). Unfortunately I don't have a test .mid file where this is differently. I'm using /usr/share/soundfonts/fluid3gm.cfg as timidity cfg, like in the bug report, so I assume this being set comes from the .mid file. What is actually happening here is that 2 pans in the range of 0-127 get added together to form a new (clamped) pan so first substracting 64 to move one of them to a -64 - + 63 range is correct. Maybe the drums being panned to one side was an on purpose effect in the .mid file ? I'm not 100% sure, but to me the original code seems correct here. Regards, Hans
