P.S. Somehow the bug tracker was lost in conversation, so adding it back.
Hi, thanks for taking the time to reply on this old issue. Let me respond to a couple of your remarks and statements: RDS schrieb am 18.10.2021 18:03 (GMT +02:00): > [...} > At some point in my convo with Mike I said I was going to dig into the systemd > code to find the root cause on that side of the issue (i.e. in a sense systemd > and tinyproxy "work together" to create the bug, but only in a sense). I did > not follow through on this. I apologize. I might be willing to do this (but > I'm > not promising) if this issue's a big deal for Timo, as my guess is that the > better (only reasonalbe?) deterministic solution to bug #968322 is in systemd > rather than tinyproxy. First off, it's not a big deal for me. I only marked this issue with the severity important because that was the severity of the original issue. But since there seems to be no real fallout from this issue, I'm absolutely fine to edit the systemd unit locally adding the SuccessExitStatus=2 directive. > On Monday, October 18th, 2021 at 9:32 AM, RDS <[email protected]> wrote: >> [...] >> (1) The fix pushed to prod by the tinyproxy Debain package team for #968322 >> was a statistical fix. I reported to them that it improved the false negative >> rate for me, I don't remember by how much, but I think quite a bit. But, yes, >> it's not deteministic. I see. Maybe I should have read the original report more thoroughly, as I assumed the fix is supposed to fix the issue under all circumstances. >> [...] >> (2) I'm not clear which state systemd is reporting for tinyproxy's stop >> status >> from this description: >> >> > I still found out one thing of note, though. I tried specifying an ExecStop >> command like so: >> >> > >> >> > ExecStop=/usr/bin/kill -TERM $MAINPID >> >> > >> >> > With this, after stopping the service, `systemctl status tinyproxy' >> showed that the kill command returned 0, but the main process >> returned >> 2. It seems to me that this contradicts the following statement in >> the >> original bug report which was: >> >> > >> >> > > The issue is more likely caused by systemd paying attention to >> the >> return value of its SIGTERM send calls [...] >> >> > >> >> > I don't know whether that is helpful in terms of solving the cause >> for the issue. But I thought, I'd at least mention it. >> >> >> In this case is systemd reporting tinyproxy in a failed stopped state or >> "good" one? If "failed", then it does seem a bit of a contradiction. If it's >> reporting tinyproxy in a good stopped state, then it might not be a >> contradiction, as it's reporting what the ExecStop command told it. It reports the unit as failed. So, systemctl reports the state (or exit code) of the main process, not the kill command or SIGTERM call. Regards, Timo
