Control: tags -1 + patch
On 2021-10-01 22:50 +0200, Adam Borowski wrote:
> Source: ytree
> Version: 1.99pl1-2
> Severity: serious
> Tags: ftbfs
> Justification: fails to build from source (but built successfully in the past)
>
> Hi!
> I'm afraid that your package fails to build with:
>
> input.c: In function ‘InputChoise’:
> input.c:352:3: error: format not a string literal and no format arguments
> [-Werror=format-security]
> 352 | mvprintw( LINES - 2, 1, msg );
> | ^~~~~~~~
>
> To fix: either use mvwaddstr() or add a "%s" before msg.
I have attached a patch that does the latter. For the change in ncurses
which triggered the FTBFS, see #993179.
Cheers,
Sven
From 015f63a98be5dc60ff5c66f24693de929c2cb6b9 Mon Sep 17 00:00:00 2001
From: Sven Joachim <[email protected]>
Date: Sat, 16 Oct 2021 09:11:37 +0200
Subject: [PATCH] Fix string format error with recent ncurses
---
input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/input.c b/input.c
index c55b3da..28bc4a0 100644
--- a/input.c
+++ b/input.c
@@ -349,7 +349,7 @@ int InputChoise(char *msg, char *term)
curs_set(1);
leaveok(stdscr, FALSE);
- mvprintw( LINES - 2, 1, msg );
+ mvprintw( LINES - 2, 1,"%s", msg );
RefreshWindow( stdscr );
doupdate();
do
--
2.33.0
