Hi, On 2021/06/11 16:23, David Kalnischkies wrote: > The patch[0] we use here is rather simplistic and does exactly what the > README.Debian file says, as in: pick it up from ~/go/bin/gopls. So, this > is technically not a bug, but documented behaviour… close kthxbye ;P
:P I definitely should have read README.Debian > If you could provide a (modified) patch to look at GOPATH first that > would be nice. I don't have experience with Go apart from doing what the > README said back than I adopted this package(set) and a smoke test so > someone with actual go experience who can tell if its working would be > cool! > > I think what we should arrive at is configured-path or /usr/bin/gopls¹ or > $GOPATH/bin/gopls or ~/go/bin/gopls (although that is probably the > default of $GOPATH). Upstream isn't going to be interested in any of > this though, as you see in the patch they just use the binary they embed > like they do for all the other things™, but I have already resigned to > *go* a patch-heavy approach with these packages here so that is fine. > (¹ or actually search in all of PATH now that I wrote this…) Sure, I'm having a look at it. It seems the FindExecutableWithFallback only expects 1 fallback, so it will need some modification to ShouldEndableGoCompleter() and GoCompleter(). I think the hierarchy you have described is correct (with PATH search over /usr/bin/gopls). > [1] I am not too sure which version that is though. I got the ycmd > testsuite mostly running earlier this week, but the go part is still > mostly red. I hope it is just 'not the version upstream wrote their > tests again' (as with clangd) but I haven't got that far in testing. If I get a chance, I can take a look. No promises on the time-frame though -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze ⢿⡄⠘⠷⠚⠋⠀ Debian Developer ⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze
