Package: piuparts Version: 1.1.4 Severity: important User: [email protected] Usertags: origin-ubuntu impish
Dear Maintainer, The attached patch will fix a FTBFS with golang-1.16. This bug report was also filed in Ubuntu and can be found at http://launchpad.net/bugs/1939171 The description, from Brian Murray, follows: In https://launchpadlibrarian.net/551476957/buildlog_ubuntu-impish-amd64.piuparts_1.1.4_BUILDING.txt.gz we can see the following: touch build-stamp (cd helpers/debiman-piuparts-distill && go build) go: go.mod file not found in current directory or any parent directory; see 'go help modules' make[2]: *** [Makefile:61: build-master-stamp] Error 1 make[2]: Leaving directory '/<<PKGBUILDDIR>>' make[1]: *** [debian/rules:12: override_dh_auto_build] Error 2 make[1]: Leaving directory '/<<PKGBUILDDIR>>' make: *** [debian/rules:9: binary] Error 2 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 This happens with piuparts version 1.1.4 and a test rebuild of 1.12 using golang-go (which depends on golang-1.16-go) also failed. -- System Information: Debian Release: 11.0 APT prefers impish APT policy: (500, 'impish') Architecture: amd64 (x86_64) Foreign Architectures: i386
>From 63a6d460c8578ec9b5e2c400d7d9ec5b22f14f81 Mon Sep 17 00:00:00 2001 From: Brian Murray <[email protected]> Date: Fri, 6 Aug 2021 12:49:18 -0700 Subject: [PATCH] Fix FTBFS w/ golang-1.16 --- CONTRIBUTING | 1 + Makefile | 2 +- debian/changelog | 7 +++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING b/CONTRIBUTING index 932bee56..5d1f732d 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -16,6 +16,7 @@ or to the tracking bug: <bugnumber>@bugs.debian.org. One possible workflow: git clone https://salsa.debian.org/debian/piuparts.git + cd piuparts git checkout origin/develop -b <topicname> <edits> git commit -a diff --git a/Makefile b/Makefile index df373eb5..ff7b7ca0 100644 --- a/Makefile +++ b/Makefile @@ -58,7 +58,7 @@ build-stamp: $(SCRIPTS_GENERATED) $(DOCS_GENERATED) Makefile touch $@ build-master-stamp: - (cd helpers/debiman-piuparts-distill && go build) + (go mod init helpers/debiman-piuparts-distill && cd helpers/debiman-piuparts-distill && go build) touch $@ build-doc: $(DOCS_GENERATED) diff --git a/debian/changelog b/debian/changelog index 251b90ee..6ec38e22 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +piuparts (1.1.5) UNRELEASED; urgency=medium + + * Makefile: Execute go mod init before running go build, fixes FTBFS with + golang-1.16. (LP: #1939171) + + -- Brian Murray <[email protected]> Fri, 06 Aug 2021 12:47:14 -0700 + piuparts (1.1.3) unstable; urgency=medium [ Michael Prokop ] -- 2.31.1
