Control: retitle -1 unblock: rpm/4.16.1.2+dfsg1-3
On Wed, Jun 30, 2021 at 02:15:43AM +0300, Peter Pentchev wrote:
> On Tue, Jun 29, 2021 at 09:02:43PM +0200, Sebastian Ramacher wrote:
> > Control: tags -1 moreinfo
> >
> > On 2021-06-29 20:15:33 +0300, Peter Pentchev wrote:
[snip]
> > > ++struct taglate_s {
> > > ++ rpmTagVal stag;
> > > ++ rpmTagVal xtag;
> > > ++ rpm_count_t count;
> > > ++ int quirk;
> > > ++} const xlateTags[] = {
[snip]
> >
> > Is this constant really supposed to be part of the public ABI? This
> > looks like it could use a static modifier.
>
> Hm, you are right. At least for the moment, it does not seem that
> anything else is using it, so it does not need to be exposed in
> the public library.
>
> I'll adapt the patch, drop the symbol from the library's symbols
> file (yes, I know, it would have been so much better if it had
> never actually hit the archive... true), and upload a new version.
>
> Thanks for making me stop and think about this!Hi, This should be fixed in 4.16.1.2+dfsg1-3 that I just uploaded to unstable. FWIW, the upstream developers already accepted the patch: https://github.com/rpm-software-management/rpm/pull/1737 (and I just realized that in the hurry to forward it upstream I plain forgot to credit you for noticing it; sorry about that!) Thanks again for spotting this! unblock rpm/4.16.1.2+dfsg1-3 G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@debian.org p...@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
signature.asc
Description: PGP signature
