Source: libcddb
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath usrmerge shell
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The build path, several binary paths, and the value of the SHELL
variable are embedded in example Makefiles shipped in the package:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/libcddb.html

  ./usr/share/doc/libcddb2-dev/examples/Makefile.gz

  ACLOCAL·=·${SHELL}·'/build/1st/libcddb-1.3.2/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/libcddb-1.3.2/2nd/missing'·aclocal-1.16

  GREP·=·/bin/grep
  vs.
  GREP·=·/usr/bin/grep

  SHELL·=·/bin/bash
  vs.
  SHELL·=·/bin/sh

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are also provided.

The attached patch adjusts debian/libcddb2-dev.examples to only install
Makefile.in and Makefile.am.


If that is somehow not an option, an alternate option would be to
sanitize the Makefiles stripping the build path (or replacing with
/usr/src?), and possibly passing various variables to configure
(e.g. GREP=/bin/grep, SHELL=/bin/sh, ...).


Thanks for maintaining libcddb!


live well,
  vagrant
From e658bcb574a9cfc68f422c56671e1a13aad806fe Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Fri, 25 Jun 2021 20:57:00 +0000
Subject: [PATCH] Do not install example Makefile.

The build path, several binary paths, and the value of the SHELL
variable are embedded in a Makefile shipped in the package.

Since these values may differ with the installed system, in order to use
the example Makefiles, a person would have to regenerate them from
Makefile.am or Makefile.in, which are included in the package.
---
 debian/libcddb2-dev.examples | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/libcddb2-dev.examples b/debian/libcddb2-dev.examples
index bdd6e0e..3a5ea45 100644
--- a/debian/libcddb2-dev.examples
+++ b/debian/libcddb2-dev.examples
@@ -1,3 +1,3 @@
 examples/*.c
 examples/*.h
-examples/Makefil*
+examples/Makefile.*
-- 
2.32.0

Attachment: signature.asc
Description: PGP signature

Reply via email to