Source: volume-key Severity: normal Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: buildpath usrmerge shell X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
The build path, several binary paths, and the value of the SHELL variable are embedded in example Makefiles shipped in the package: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/volume-key.html ./usr/share/doc/volume_key/contrib/Makefile.gz ACLOCAL·=·${SHELL}·'/build/1st/volume-key-0.3.12/admin/missing'·aclocal-1.16 vs. ACLOCAL·=·${SHELL}·'/build/2/volume-key-0.3.12/2nd/admin/missing'·aclocal-1.16 GREP·=·/bin/grep vs. GREP·=·/usr/bin/grep SHELL·=·/bin/bash vs. SHELL·=·/bin/sh Since these values may differ with the installed system, in order to use the example Makefiles, a person would have to regenerate them from Makefile.am or Makefile.in, which are also provided. The attached patch adjusts debian/rules to remove the Makefile before running dh_install. If that is somehow not an option, an alternate option would be to sanitize the Makefiles stripping the build path (or replacing with /usr/src?), and possibly passing various variables to configure (e.g. GREP=/bin/grep, SHELL=/bin/sh, ...). Thanks for maintaining volume-key! live well, vagrant
From a751749dabf2dd4b87796cb5924ba7e0d0cf7cf5 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian <vagr...@reproducible-builds.org> Date: Fri, 25 Jun 2021 17:25:14 +0000 Subject: [PATCH] debian/rules: Remove Makefile to resolve reproducibility issues. The build path, several binary paths, and the value of the SHELL variable are embedded in a Makefile shipped in the package. Since these values may differ with the installed system, in order to use the example Makefiles, a person would have to regenerate them from Makefile.am or Makefile.in, which are also provided. --- debian/rules | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/rules b/debian/rules index 3e2b027..0ba6e6a 100755 --- a/debian/rules +++ b/debian/rules @@ -16,6 +16,8 @@ override_dh_auto_configure: override_dh_install: find debian/tmp -name '*.la' -print -delete + # Remove example Makefile to fix reproducibility issues + find contrib -name Makefile -print -delete dh_install override_dh_missing: -- 2.32.0
signature.asc
Description: PGP signature
