Control: severity -1 important
[Cyril Brulebois]
> Justification: doesn't fullfil its purpose out of the box
Thank you for the feedback. The severity seem to be based on the
misunderstanding that the purpose of isenkram-cli is to provide
isenkram-autoinstall-firmware, while it actually is to provide
isenkram-lookup and friends, so I set it to important which reflect the
importance of the isenkram-autoinstall-firmware script.
When that is said, the bugs you found should be fixed and I am having a
look at your patches.
> Finally, I haven't seen this return anything:
>
> appstreamlookup() {
> fwfile="$1"
> appstreamcli what-provides firmware:runtime "$fwfile" | \
> awk '/Package:/ { print $2}'
> }
>
> I'm no appstream expert though, so I have no idea whether that's an
> appstreamcli limitation, a usage problem from the caller side, and/or
> some requirements that aren't met on the setup side. It's still a little
> surprising to me as both code and comments suggest appstream is the
> preferred way to get the information…
I am not an appstream expert either, but lets bring "my" expert Matthias
Klumpp into the loop. Perhaps he got a clue what is going wrong here?
I ran this test on a few of my machines, and it provide several matches:
for f in $(find /lib/firmware/ -type f |sed s%/lib/firmware/%%); do
appstreamcli what-provides firmware:runtime $f
done
--
Happy hacking
Petter Reinholdtsen
