Package: hexedit Version: 1.5-1 Severity: important Using an ampersand at the end of a command means it never fails:
$ true ; false & echo $?
[1] 199336
0
[1]+ Exit 1 false
$ false ; false & echo $?
[1] 199355
0
[1]+ Exit 1 false
Using xvfb-run with a terminal curses UI doesn't do anything over
running it without xvfb-run.
hexedit-1.5 $ xvfb-run ls | head -n1
autogen.sh
hexedit-1.5 $ head -vn-0 debian/tests/*
==> debian/tests/control <==
Test-Command: hexedit -h 2>&1 | grep '^usage'
Restrictions: superficial
Test-Command: xvfb-run -a hexedit debian/tests/control &
Depends: @, xauth, xvfb
I suggest dropping the test in question, unless you can figure out a
way to properly test a curses user interface.
I think with printf, pipetty and ansi2txt (from colorized-logs) you can
get an autopkgtest that actually exercises the user interface:
$ rm -f foo bar ; echo oof > foo ; echo rab > bar ; printf 'foo\n\trab\x18y'
| pipetty hexedit 2>&1 | ansi2txt | tr '\r' '\n' ; head -vn-0 foo bar ; cmp foo
bar
BFile name: foo
00000000 6F 6F 66 0ABoBof.
00000010
00000020
00000030
00000040
00000050
00000060
00000070
00000080
00000090
000000A0
000000B0
000000C0
000000D0
000000E0
000000F0
00000100
00000110
00000120
00000130
00000140
00000150
00000160
---
foo--0x0/0x4--0%---------------------------------------------------B72rB**125%B61aB250B62bB375
Save changes (Yes/No/Cancel) ?
==> foo <==
rab
==> bar <==
rab
-- System Information:
Debian Release: 11.0
APT prefers testing-debug
APT policy: (900, 'testing-debug'), (900, 'testing'), (800,
'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700,
'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental'),
(500, 'testing-security')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-7-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages hexedit depends on:
ii libc6 2.31-12
ii libncurses6 6.2+20201114-2
ii libtinfo6 6.2+20201114-2
hexedit recommends no packages.
hexedit suggests no packages.
--
bye,
pabs
https://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part

