Package: debianutils
Version: 4.8.6.1
Severity: wishlist

Dear Maintainer,

add-shell uses the following construct to ensure that the last line of
/etc/shells contains a newline:

if ! awk '{print}' "$file" > "$tmpfile"

I'd like to request that it be changed to

if ! grep '' "$file" > "$tmpfile"

awk causes some issues during bootstrapping a new system as it requires
the use of update-alternatives to create the necessary symlink. grep
doesn't have this issue meaning that, for example, installing dash no
longer depends on awk being configured first.

Additionally doing this would be another step to removing awk from the
Essential: yes set.

Patch against unstable:
diff -urN debianutils.orig/usr/sbin/add-shell debianutils/usr/sbin/add-shell
--- debianutils.orig/usr/sbin/add-shell 2020-09-27 17:25:47.000000000 +0000
+++ debianutils/usr/sbin/add-shell      2021-03-16 11:50:42.941481568 +0000
@@ -17,7 +17,7 @@
 }
 trap cleanup EXIT
 
-if ! awk '{print}' "$file" > "$tmpfile"
+if ! grep '' "$file" > "$tmpfile"
 then
         cat 1>&2 <<EOF
 Either another instance of $0 is running, or it was previously interrupted.


Thanks,

-- System Information:
Debian Release: 10.9
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-16-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages debianutils depends on:
ii  libc6  2.28-10

debianutils recommends no packages.

debianutils suggests no packages.

-- no debconf information

Reply via email to