Source: qtermwidget
Version: 0.16.1
Severity: wishlist
Tags: patch
Dear Maintainer,
while using qterminal I observed that URLs conatined in my BibTeX files are not
properly recognised. I found the reason in the closing brace not present in
the FullUrlRegExp (lib/Filter.cpp). However, BibTeX files use braces to
enclose values, e.g. an URL, and I always read my BibTeX files in a terminal.
So, it is nice to have the URLs written in my BibTeX files and enclosed in
braces there to be correctly trasnfered to my browser.
I have added the closing brace as delimiting character to FullUrlRegExp and
re-built the package. With the patch enclosed it works fine for me.
Otherwise, many thanks for your work in providing and maintaining this
software.
Have a nice day -- JHK
-- System Information:
Debian Release: bullseye/sid
APT prefers testing-security
APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-4-amd64 (SMP w/16 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: Adds closing brace as delimiting character to FullUrlRegExp
The closing brace happens to be present in BibTeX files to delimit URLs as
value of the url field, for example.
---
Last-Update: 2021-03-14
--- qtermwidget-0.16.1.orig/lib/Filter.cpp
+++ qtermwidget-0.16.1/lib/Filter.cpp
@@ -464,8 +464,8 @@ void UrlFilter::HotSpot::activate(const
//regexp matches:
// full url:
-// protocolname:// or www. followed by anything other than whitespaces, <, >,
' or ", and ends before whitespaces, <, >, ', ", ], !, comma and dot
-const QRegExp
UrlFilter::FullUrlRegExp(QLatin1String("(www\\.(?!\\.)|[a-z][a-z0-9+.-]*://)[^\\s<>'\"]+[^!,\\.\\s<>'\"\\]]"));
+// protocolname:// or www. followed by anything other than whitespaces, <, >,
' or ", and ends before whitespaces, <, >, ', ", ], }, !, comma and dot
+const QRegExp
UrlFilter::FullUrlRegExp(QLatin1String("(www\\.(?!\\.)|[a-z][a-z0-9+.-]*://)[^\\s<>'\"]+[^!,\\.\\s<>'\"\\]\\}]"));
// email address:
// [word chars, dots or dashes]@[word chars, dots or dashes].[word chars]
const QRegExp
UrlFilter::EmailAddressRegExp(QLatin1String("\\b(\\w|\\.|-)+@(\\w|\\.|-)+\\.\\w+\\b"));
