tags 803329 +patch thanks On Mon, 2021-03-08 at 09:56 -0300, Felipe Sateler wrote: > I would accept a patch moving the completion files to the pulseaudio-utils > package.
Great! Patch attached. Cheers, Kevin
>From a6e3fc1f1e0057c7f10df61c830619b54a456a92 Mon Sep 17 00:00:00 2001 Message-Id: <a6e3fc1f1e0057c7f10df61c830619b54a456a92.1615212717.git.ke...@kevinlocke.name> From: Kevin Locke <ke...@kevinlocke.name> Date: Mon, 8 Mar 2021 06:16:29 -0700 Subject: [PATCH] Move shell completion scripts to pulseaudio-utils The shell completion scripts support commands from both the pulseaudio package and pulseaudio-utils package, which may be installed without pulseaudio (e.g. for use with PipeWire configured for PulseAudio compatibility). Ship the completions in pulseaudio-utils to cover this case. Note that the completion for the pulseaudio command will be available if the pulseaudio package is installed, since it depends on pulseaudio-utils. Also move the Lintian override for script-not-executable and add one for bash-completion-with-hashbang. I'm in favor of fixing these, rather than overriding them, but not sufficiently to pursue it right now. Fixes: #803329 Signed-off-by: Kevin Locke <ke...@kevinlocke.name> --- debian/pulseaudio-utils.install | 2 ++ debian/pulseaudio-utils.lintian-overrides | 2 ++ debian/pulseaudio.install | 2 -- debian/pulseaudio.lintian-overrides | 1 - 4 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 debian/pulseaudio-utils.lintian-overrides diff --git a/debian/pulseaudio-utils.install b/debian/pulseaudio-utils.install index bda341aeb..6f31a3036 100644 --- a/debian/pulseaudio-utils.install +++ b/debian/pulseaudio-utils.install @@ -9,6 +9,7 @@ usr/bin/padsp usr/bin/pax11publish usr/bin/pasuspender usr/bin/pa-info +usr/share/bash-completion/completions/* usr/share/man/man1/pacat.1 usr/share/man/man1/pacmd.1 usr/share/man/man1/pactl.1 @@ -19,3 +20,4 @@ usr/share/man/man1/parec.1 usr/share/man/man1/parecord.1 usr/share/man/man1/pasuspender.1 usr/share/man/man1/pax11publish.1 +usr/share/zsh diff --git a/debian/pulseaudio-utils.lintian-overrides b/debian/pulseaudio-utils.lintian-overrides new file mode 100644 index 000000000..0b3e03c3f --- /dev/null +++ b/debian/pulseaudio-utils.lintian-overrides @@ -0,0 +1,2 @@ +pulseaudio-utils: bash-completion-with-hashbang usr/share/bash-completion/completions/pulseaudio +pulseaudio-utils: script-not-executable usr/share/bash-completion/completions/pulseaudio diff --git a/debian/pulseaudio.install b/debian/pulseaudio.install index 25046237b..c0e99572a 100755 --- a/debian/pulseaudio.install +++ b/debian/pulseaudio.install @@ -80,7 +80,6 @@ usr/lib/pulse-*/modules/module-x11*.so usr/lib/pulse-*/modules/module-allow-passthrough.so [linux-any] usr/lib/pulse-*/modules/module-systemd-login.so [linux-any] usr/lib/systemd/user/pulseaudio.* -usr/share/bash-completion/completions/* usr/share/locale usr/share/man/man1/pulseaudio.1 usr/share/man/man5/default.pa.5 @@ -91,4 +90,3 @@ usr/share/man/man1/start-pulseaudio-x11.1 [linux-any] usr/share/pulseaudio/alsa-mixer [linux-any] usr/share/alsa usr/share/apport -usr/share/zsh diff --git a/debian/pulseaudio.lintian-overrides b/debian/pulseaudio.lintian-overrides index 6d67fe20c..6a438ed94 100644 --- a/debian/pulseaudio.lintian-overrides +++ b/debian/pulseaudio.lintian-overrides @@ -1,4 +1,3 @@ # These are not meant to be executed pulseaudio: script-not-executable etc/pulse/*.pa -pulseaudio: script-not-executable usr/share/bash-completion/completions/pulseaudio pulseaudio: description-starts-with-package-name -- 2.30.1
