On 2021-01-31, harr...@gmx.ph wrote: > I thought I might as well add the remaining 24 armhf boards to it while > I was at it, so it now has 26 armhf and 11 arm64 boards, matching what's > in debian/targets, sorted by U-Boot board name.
Hrm. This turns out to make it hard to consider merging the patch as it
no longer applies, and this aspect isn't really at the heart of this bug
report...
That said, the work you did on that was a huge help and I'll apply the
board-specific changes where appropriate for bullseye (after sorting
them).
> I think it would be nice if this simplification could be included in
> bullseye. What do you think?
Seems unlikely at this point, sorry I took so long to take a look at
this.
> diff --git a/debian/bin/u-boot-install-sunxi b/debian/bin/u-boot-install-sunxi
> index 4f80e01099..4b862fd3ff 100755
> --- a/debian/bin/u-boot-install-sunxi
> +++ b/debian/bin/u-boot-install-sunxi
...
> + "NextThing C.H.I.P.") TARGET="/usr/lib/u-boot/CHIP" ;;
I know the CHIP can't be installed with this method, so I left this one
out of my patch adding boards. Fairly sure the rest can be...
> *)
> echo >&2 "ERROR: Unknown system: ${dtmodelname}"
> - echo >&2 "Specify target: TARGET=/usr/lib/u-boot/UBOOT"
> + echo >&2 "Specify target:
> TARGET=/usr/lib/u-boot/<board_name>"
> exit 1
> ;;
> esac
Hrm. Guess it is clearer, but also pretty minor...
> -echo "Writing u-boot SPL image"
> -dd conv=notrunc if=${spl} of="$DEV" bs=8k seek=1
> +imfile="u-boot-sunxi-with-spl.bin"
>
> -if [ -n "$itb" ]; then
> - echo "Writing u-boot FIT image"
> - dd conv=notrunc if=${itb} of="$DEV" bs=8k seek=5
> +if [ ! -f "${TARGET}/${imfile}" ]; then
> + echo >&2 "$0: no ${imfile} image file in ${TARGET}"
> + exit 1
> fi
>
> -sync "$DEV"
> +echo "Writing U-Boot image to ${DEV}"
> +dd conv=fsync,notrunc if="${TARGET}/${imfile}" of="$DEV" bs=8k seek=1
And this, we'll leave for bookworm...
live well,
vagrant
signature.asc
Description: PGP signature
