On Fri, Feb 26, 2021 at 10:54:32PM +0100, Lucas Nussbaum wrote: > On 26/02/21 at 20:07 +0100, Lucas Nussbaum wrote: > > On 14/02/21 at 08:48 +0100, Evgeni Golov wrote: > > > On Sat, Feb 13, 2021 at 11:57:52PM +0100, Thomas Lange wrote: > > > > IMO we cannot know which device name is used by the users > > > > virtualisation environment. > > > > So, what is the be setting without knowing the device name? > > > > > > > > Or is /dev/sda used in most enviroments? > > > > > > For VirtualBox sda is a pretty safe bet, for libvirt it'd be either sda > > > or vda (and I think we could set both in debconf, as that's a > > > multiselect). AWS has another one, vxda I think? But this explicit bug > > > is about vagrant (so virtualbox and libvirt) only anyways. > > > > > > The only thing to consider with this approach: it should only be done > > > when preparing images, not installing "real" systems. So in the > > > cloud.d.o context that's safe, but probably not as a generic default in > > > FAI and other tools. > > > > Maybe a better approach (but still hackish) would be to set it at first > > boot, in a way similar to > > https://salsa.debian.org/cloud-team/debian-vagrant-images/-/blob/master/config_space/files/etc/systemd/system/generate-sshd-host-keys.service/VAGRANT > > > > Running Something like: > > echo grub-pc grub-pc/install_devices multiselect $(awk '{ if ($2 == "/") { > > sub(/1$/, "", $1) ; print $1 } }' /proc/mounts) | debconf-set-selections > > Tentative patch: > https://salsa.debian.org/cloud-team/debian-vagrant-images/-/commit/b82d522f65b507767f909b2b9471c5a9ade75e05
Thanks Lucas! That looks quite like the "first-boot script" I mentioned in the original report. One q tho: isn't `findmnt --noheadings --output SOURCE /` easier to read than running awk on /proc/mounts? It's in util-linux and that's essential anyways :) Evgeni
