On Mon, Apr 17, 2006 at 09:50:44AM +0200, Andreas Barth wrote:
> I found a couple of things where dpkg-source 2.0 is too strict:
>
> 1. it refuses if a patch starts with "diff -Nur ...." as comment. Fix:
> add a "or /^diff /", so that the check line looks like:
> while (defined($_ = <DIFF>) && !(/^--- / or /^Index:/ or /^diff /)) {
Hmm, we accept comments before the first hunk but not between hunks. We
should consider allowing that.
> 2. It refuses to accept it, if the first filename is postceded (hm, is
> this english?) with e.g. a ~ - which I do quite often.
>
> --- mgetty-1.1.33.orig/fax/faxrunq.in~ 2005-05-10 20:36:15.852961681 +0000
> +++ mgetty-1.1.33/fax/faxrunq.in 2005-02-27 11:57:31.000000000 +0000
Confirmed, but unsure wether we should support it.
> 3. It ignores any patches with a . in their name - without even a
> warning. (That's a "IMHO too strict".)
That's exactly like run-parts behave, so that's not really inconsistent.
Unlikely to be changed at this point I think.
Gruesse,
--
Frank Lichtenheld <[EMAIL PROTECTED]>
www: http://www.djpig.de/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
