Hi Santiago,

On Mon, Feb 8, 2021 at 3:27 PM Sudip Mukherjee
<[email protected]> wrote:
>
> On Mon, Feb 8, 2021 at 3:12 PM Santiago Ruano Rincón
> <[email protected]> wrote:
> >
> > El 06/02/21 a las 16:46, Sudip Mukherjee escribió:
> > > On Sat, Feb 6, 2021 at 4:11 PM Sudip Mukherjee
> > > <[email protected]> wrote:
> > > >
> > > > Hi Santiago,
> > > >
> > > > On Fri, Feb 05, 2021 at 11:27:46AM +0100, Santiago Ruano Rincón wrote:
> > > > > Package: offlineimap3
> > > > > Version: 0.0~git20210105.00d395b+dfsg-2
> > > > > Severity: important
> > > > >
> > > > > Dear offlineimap3 maintainer,
> > > > >

<snip>

> > > From your trace it seems you are using Curses and I do see problems if
> > > I mention 'blinkenlights' while running offlineimap.
> > > Your offlineimaprc will help, but also can you please comment the "ui
> > > = " in your offlineimaprc and check if you still get both these
> > > issues.
> >
> > Indeed, I can input my password if I comment out ui = Blinkenlights.
> > offlineimaprc attached. Thanks!

Can you please try the attached patch and confirm if it fixes both
your issues with blinkenlights..


-- 
Regards
Sudip
From 07598cc8b632fc13c38687c9dadba7757b062503 Mon Sep 17 00:00:00 2001
From: Sudip Mukherjee <[email protected]>
Date: Tue, 16 Feb 2021 23:27:06 +0000
Subject: [PATCH] Use str password with Curses

Signed-off-by: Sudip Mukherjee <[email protected]>
---
 offlineimap/imapserver.py | 1 -
 offlineimap/ui/Curses.py  | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/offlineimap/imapserver.py b/offlineimap/imapserver.py
index 3970541..0086ab4 100644
--- a/offlineimap/imapserver.py
+++ b/offlineimap/imapserver.py
@@ -216,7 +216,6 @@ class IMAPServer:
 
         retval = NULL.join((authz, authc, passwd))
         logsafe_retval = NULL.join((authz, authc, '(passwd hidden for log)'))
-        self.ui.debug('imap', '__plainhandler: returning %s' % logsafe_retval)
         return retval
 
     def __xoauth2handler(self, response):
diff --git a/offlineimap/ui/Curses.py b/offlineimap/ui/Curses.py
index 03f4d26..dfad308 100644
--- a/offlineimap/ui/Curses.py
+++ b/offlineimap/ui/Curses.py
@@ -583,6 +583,10 @@ class Blinkenlights(UIBase, CursesUtil):
         finally:
             self.unlock()
             self.inputhandler.input_release()
+
+        # We need a str password
+        if isinstance(password, bytes):
+            return password.decode(encoding='utf-8')
         return password
 
     def setupwindows(self, resize=False):
-- 
2.30.0

Reply via email to