On Tue 2019-02-26 02:59:54 -0500, Antoine Beaupré wrote:
> The patch was accepted upstream, but I would suggest it might be a good
> addition to buster as well...
>
> Any takers? It's a fairly trivial patch...

fwiw, i think this should be included in the next buster point release,
if we can get a new version of emacs in there.  the one-line patch is
pretty straightforward and shouldn't cause any problems.

You can even cherry-pick it from upstream based on commit ID
90177d7f12d25e403abc6f1bdf242aed308a7bb8, which is also attached here.
(i'd offer a patch myself on salsa, but it seems to be using git-dpm,
and i don't really understand git-dpm well enough to try)

      --dkg

From 90177d7f12d25e403abc6f1bdf242aed308a7bb8 Mon Sep 17 00:00:00 2001
From: Daniel Kahn Gillmor <[email protected]>
Date: Fri, 18 Jan 2019 03:12:07 -0500
Subject: [PATCH] Avoid elisp crash for OpenPGP User IDs with no e-mail address

* lisp/gnus/mml-sec.el (mml-secure-check-user-id): Verify that
there is an e-mail address in the current User ID before trying
to downcase it.  (Bug#34121)

Copyright-paperwork-exempt: yes
---
 lisp/gnus/mml-sec.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 8c485fec376..4fca4ce67b7 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -658,6 +658,8 @@ The passphrase is read and cached."
     (catch 'break
       (dolist (uid uids nil)
 	(if (and (stringp (epg-user-id-string uid))
+                 (car (mail-header-parse-address
+                       (epg-user-id-string uid)))
 		 (equal (downcase (car (mail-header-parse-address
 					(epg-user-id-string uid))))
 			(downcase (car (mail-header-parse-address
-- 
2.29.2

Attachment: signature.asc
Description: PGP signature

Reply via email to