Hi Thomas, On Sat, Apr 15, 2006 at 11:13:43AM +0200, Thomas Antepoth wrote: > In line 1413 there is a socket created without specifying > a timeout parameter. > > This might lead to a stalled read() when the connection drops > during the network operation and to a hanging ddclient > process which does not update the ip addresses any more. > > On 4 Sites we observed about 1 hang per month.
Makes sense.
> Suggestion:
> Change this line 1413:
>
> } elsif (! defined($sd = IO::Socket::INET->new(PeerAddr => $peer, PeerPort =>
> $port, Proto => 'tcp'))) {
>
> to:
>
> } elsif (! defined($sd = IO::Socket::INET->new(PeerAddr => $peer, PeerPort =>
> $port, Proto => 'tcp', Timeout => opt('timeout') ))) {
This still applies in version 3.6.7, I just changed my local working
copy and uploaded a new package with the changes.
Greetings
Torsten
signature.asc
Description: Digital signature
