Hi again,

Le 27/11/2020 à 10:07, Andreas Tille a écrit :
Control: block -1 by 975945

Hi Pierre,

On Sat, Nov 21, 2020 at 10:00:08PM +0000, Joerg Jaspert wrote:
The statement from upstream in their txt file beside is

---
Sources for the utility JAR file included with this package can be
found at https://github.com/rajarshi/cdkr/tree/master/rcdkjar. They
are not included with the package since they require a few large
dependency JAR files, which would bloat the package
---

Ahhh, I should have read this text file (or this mail more carefully).
I've now injected cdkr in Salsa[1] (granted you commit permissions) and
opened ITP #975945.  I wonder whether you might be able to fix the ant
build to create the JAR in question (and whether we really need
com.objectplanet.image.PngEncoder.jar - I could do the needed
preparation if you are short in time).

On cdkr: I've patched build.xml so that the build can be done; I've also added a missing dependency and specified the classpath. I've pushed to Salsa. Now the package can be built, lintian just asks to change the section from "science" to "java".

I've stumbled upon the tests: they are written with paths on upstream developer's computer, some of them involve classes that are not in the jar to be tested... Yet some of them could certainly be run after being rigorously patched. If you would prefer to have some tests running tell me, I will be volunteering to try to have them.

On r-cran-rcdk: I don't see which part of the code would be using com.objectplanet.image.PngEncoder.jar, so I think we could just ignore it.


Kind regards

        Andreas.

[1] https://salsa.debian.org/r-pkg-team/cdkr


Best regards,
Pierre

Reply via email to