Hey Mattia,

> Thank you for this, I've now merged it.
Thanks!

> Also, I personally hate changing long-standing defaults.
Yeah, I can see that.

> > Maybe the default could be changed to only scan the current directory
> > *if* it is a debian source tree, and default to recursive scanning if
> > not? That would support both the "Run on a single package" and "Run on a
> > collection of packages" usecases neatly?
> 
> That's too surprising.  Changing behaviour that way just due to the
> surrounding files is too unexpected for me.
It might end up doing the right thing in most cases, but I can see it
could also be surprising, which is indeed a downside of this approach.

> Regardless, I'd accept an MR that would implement:
Ok, sounds good. I'd like to submit such a MR, but it's highly likely
that I'll not find the time in the near future, or maybe not at all, so
if anyone else wants to do this, feel free.

> Also perhaps add a relevant config item that would switch the default
> locally, so that one can set, e.g., USCAN_RECURSIVE=no in their
> ~/.devscripts and have it re-enabled with --recursive as needed.
That also sounds like a good idea, that at least allows people to change
their own defaults.

> > One open question is what constitutes a "source tree" exactly for the
> > purpose of the default operation.
> 
> [ -f debian/changelog -a -f debian/watch ] should do IMHO.  Without
> parsing, it would just fail a few moments later anyway.
Given you do not want to change the default as I suggested, I think this
question is not actually relevant anymore.

Gr.

Matthijs

Attachment: signature.asc
Description: PGP signature

Reply via email to