Hi Norbert! On Thu, Jul 02, 2020 at 08:47:53PM +0900, Norbert Preining wrote: > At the moment we do not depend on any of that but solely on > python3-sip-dev > is that enough?
python3-sip-dev is part of sip4, please remove that build-dependency.
If you patched the code to use /usr/bin/sip5, then you need to build-depend
on sip5-tools.
> Ok, I switched from ${sip3:Depends} to python3-pyqt5.sip.
> Do you guarantee that this is enough and properly superseeds
> ${sip3:Depends}?
Yes, that should be enough.
I forgot to mention that python3-pyqt5 already depends on python3-pyqt5.sip,
so you get that dependency even if you do not list it explicitly.
> Furthermore, we call
> dh_sip3 -pcalibre-bin
> what should happen with that?
Please remove it too. dh_sip3 was a helper that added a dependency on
a sip that the package was built with, but now that build-time and run-time
parts of sip are different packages with separate versions (sipbuild and
PyQt5.sip), it is hard to provide such a helper.
Maybe there will be dh_pyqt5sip some day, but not in the near future.
> The changes I made are in the last two commits in the master branch in
> https://github.com/norbusan/calibre-debian
>
> Any comments from your side?
If it builds fine, works fine, and does not build-depend or depend on
anything from src:sip4 then it's fine.
If there are any problems with the above points, please ask me.
Also please bump build-dependency on pyqt5-dev to 5.15.0+dfsg-1+exp1~,
as it is the first version that ships .sip files in the new location.
--
Dmitry Shachnev
signature.asc
Description: PGP signature
