On Thu, Jul 2, 2020 at 20:01, Pirate Praveen <[email protected]>
wrote:
I plan to at least verify the syntax is still valid for ruby 2.5 for
every new release.
See
https://salsa.debian.org/ruby-team/gitlab/-/blob/master/debian/check-ruby-syntax.sh#L4
pravi@ilvala2:~/forge/ruby-team/gitlab$ find . -name \*.rb -exec ruby
-wc {} \; 2>&1 | grep error
./lib/gitlab/golang.rb:36: syntax error, unexpected ']'
./lib/gitlab/golang.rb:99: syntax error, unexpected end-of-input,
expecting keyword_end
./spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb:25:
warning: possibly useless use of | in void context
./spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb:26:
warning: possibly useless use of | in void context
./spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb:27:
warning: possibly useless use of | in void context
./spec/factories/design_management/designs.rb:83: syntax error,
unexpected ')'
./spec/factories/design_management/designs.rb:91: syntax error,
unexpected keyword_end, expecting ')'
./spec/factories/design_management/designs.rb:127: syntax error,
unexpected keyword_end, expecting ')'
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:58:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:59:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:60:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:61:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:62:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:63:
warning: possibly useless use of | in void context
./spec/models/error_tracking/project_error_tracking_setting_spec.rb:64:
warning: possibly useless use of | in void context
./spec/models/concerns/where_composite_spec.rb:166: syntax error,
unexpected ')'
./spec/models/concerns/where_composite_spec.rb:168: syntax error,
unexpected keyword_end, expecting ')'
./spec/models/concerns/where_composite_spec.rb:182: syntax error,
unexpected keyword_end, expecting ')'
./generator_templates/active_record/migration/migration.rb:6: syntax
error, unexpected '<'
./generator_templates/active_record/migration/migration.rb:6: syntax
error, unexpected tCONSTANT, expecting end-of-input
./generator_templates/active_record/migration/create_table_migration.rb:6:
syntax error, unexpected '<'
./generator_templates/active_record/migration/create_table_migration.rb:6:
syntax error, unexpected tCONSTANT, expecting end-of-input
./generator_templates/rails/post_deployment_migration/migration.rb:6:
syntax error, unexpected '<'
./generator_templates/rails/post_deployment_migration/migration.rb:6:
syntax error, unexpected tCONSTANT, expecting end-of-input
./elasticsearch-model/spec/elasticsearch/model/adapters/active_record/import_spec.rb:51:
warning: assigned but unused variable - errors
./elasticsearch-model/spec/elasticsearch/model/adapters/mongoid/basic_spec.rb:200:
warning: assigned but unused variable - errors
So if we ignore the *_spec.rb only files in generator_templates seems
to have syntax errors. Not sure where they are actually used.
